-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove default constructor from Alpaka EDProducer base classes #47227
Remove default constructor from Alpaka EDProducer base classes #47227
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47227/43507 |
A new Pull Request was created by @makortel for master. It involves the following packages:
@cmsbuild, @fwyzard, @makortel can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
hold This PR needs #47216 to be merged first (or simultaneously). I opened it already mostly to not forget it, as I'd like to have it merged for 15_0_0_pre3. |
Pull request has been put on hold by @makortel |
enable gpu |
please test with #47216 |
+heterogeneous |
+1 Size: This PR adds an extra 24KB to repository Comparison SummarySummary:
GPU Comparison SummarySummary:
|
Now in #47233 |
@cms-sw/orp-l2 I'd like to have this PR in pre3 as well (it can be merged together with #47216) |
unhold |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @mandrenguyen, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Following #47028 and #47216 this PR removes the default constructor from Alpaka EDPRoducer base classes so that the behavior of
alpaka.synchronize
configuration parameter becomes well defined for all Alpaka modules.Resolves cms-sw/framework-team#1210
PR validation:
Code compiles (with #47216)