-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use TkPixelCPERecord
for PixelCPEFastParams*
#46852
base: master
Are you sure you want to change the base?
Use TkPixelCPERecord
for PixelCPEFastParams*
#46852
Conversation
enable gpu |
cms-bot internal usage |
test parameters:
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46852/42873 |
A new Pull Request was created by @AdrianoDee for master. It involves the following packages:
@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Moved it to draft since this technically works for pixel tracks but I have to test if this works for refitting purposes. |
Milestone for this pull request has been moved to CMSSW_15_1_X. Please open a backport if it should also go in to CMSSW_15_0_X. |
PR description:
This PR proposes
twothree things:PixelCPEFastParamsRecord
;PixelCPEFastParams
inTkPixelCPERecord
that is the record for all the other CPEs;PixelCPEFastParams
use theTkPixelCPERecord
.When we ported the code to Alpaka we introduced
PixelCPEFastParamsRecord
without a specific reason but the fact that we were learning how to write an AlpakaESProduct/ESProducer
and it seemed natural to have it in a new record.PR validation:
runTheMatrix.py -w upgrade -l 12834.402
runs.