CA Extension to strips #47090
CA Extension to strips #47090
Conversation
|
bdanzi, CMSSW_15_0_X branch is closed for direct updates. cms-bot is going to move this PR to master branch. |
|
cms-bot internal usage |
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47090/43269
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47090/43271
|
|
Pull request #47090 was updated. |
|
please test |
|
Pull request #47090 was updated. |
|
test parameters:
|
|
@cmsbuild, please test |
cmsbuild
added
tests-started
tests-rejected
and removed
tests-pending
tests-started
labels
|
-1 Failed Tests: Build BuildI found compilation error when building: /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02874/el8_amd64_gcc12/external/cuda/12.8.0-15bfa86985d46d842bb5ecc3aca6c676/bin/nvcc -dlink -L/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_15_0_X_2025-01-29-2300/static/el8_amd64_gcc12 -L/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02874/el8_amd64_gcc12/cms/cmssw/CMSSW_15_0_X_2025-01-29-2300/static/el8_amd64_gcc12 -L/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_15_0_X_2025-01-29-2300/biglib/el8_amd64_gcc12 -L/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_15_0_X_2025-01-29-2300/lib/el8_amd64_gcc12 -L/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02874/el8_amd64_gcc12/cms/cmssw/CMSSW_15_0_X_2025-01-29-2300/biglib/el8_amd64_gcc12 -L/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02874/el8_amd64_gcc12/cms/cmssw/CMSSW_15_0_X_2025-01-29-2300/lib/el8_amd64_gcc12 -L/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02874/el8_amd64_gcc12/cms/cmssw/CMSSW_15_0_X_2025-01-29-2300/external/el8_amd64_gcc12/lib -L/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02874/el8_amd64_gcc12/external/cuda/12.8.0-15bfa86985d46d842bb5ecc3aca6c676/lib64/stubs -lcudadevrt --diag-suppress 20014 -std=c++20 -O3 --generate-line-info --source-in-ptx --display-error-number --expt-relaxed-constexpr --extended-lambda -gencode arch=compute_60,code=[sm_60,compute_60] -gencode arch=compute_70,code=[sm_70,compute_70] -gencode arch=compute_75,code=[sm_75,compute_75] -gencode arch=compute_80,code=[sm_80,compute_80] -gencode arch=compute_89,code=[sm_89,compute_89] -Wno-deprecated-gpu-targets -diag-suppress=3012 -diag-suppress=3189 -Xcudafe --diag_suppress=esa_on_defaulted_function_ignored -Xcudafe --gnu_version=120300 --cudart shared -DALPAKA_DEFAULT_HOST_MEMORY_ALIGNMENT=128 -DALPAKA_DISABLE_VENDOR_RNG -DALPAKA_ACC_GPU_CUDA_ENABLED -DALPAKA_ACC_GPU_CUDA_ONLY_MODE -UALPAKA_HOST_ONLY --compiler-options '-O3 -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -ftree-vectorize -Werror=array-bounds -Werror=format-contains-nul -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -Wno-error=array-bounds -Warray-bounds -fuse-ld=bfd -felide-constructors -fmessage-length=0 -Wall -Wno-non-template-friend -Wno-long-long -Wreturn-type -Wextra -Wpessimizing-move -Wclass-memaccess -Wno-cast-function-type -Wno-unused-but-set-parameter -Wno-ignored-qualifiers -Wno-unused-parameter -Wunused -Wparentheses -Werror=return-type -Werror=missing-braces -Werror=unused-value -Werror=unused-label -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=unused-but-set-variable -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=return-local-addr -Wnon-virtual-dtor -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-psabi -DEIGEN_DONT_PARALLELIZE -DEIGEN_MAX_ALIGN_BYTES=64 -Wno-error=unused-variable -DALPAKA_DEFAULT_HOST_MEMORY_ALIGNMENT=128 -DALPAKA_DISABLE_VENDOR_RNG -DALPAKA_ACC_GPU_CUDA_ENABLED -DALPAKA_ACC_GPU_CUDA_ONLY_MODE -DALPAKA_HOST_ONLY -DBOOST_DISABLE_ASSERTS -std=c++20 -march=x86-64-v2 -fPIC ' tmp/el8_amd64_gcc12/src/RecoVertex/PixelVertexFinding/plugins/RecoPixelVertexingPixelVertexFindingPluginsPortableCudaAsync/alpaka/vertexFinder.dev.cc.o -o tmp/el8_amd64_gcc12/src/RecoVertex/PixelVertexFinding/plugins/RecoPixelVertexingPixelVertexFindingPluginsPortableCudaAsync/RecoPixelVertexingPixelVertexFindingPluginsPortableCudaAsync_cudadlink.o nvlink error : Entry function '_ZN6alpaka6detail9gpuKernelIN17alpaka_cuda_async12vertexFinder15SortByPt2KernelENS_9ApiCudaRtENS_22AccGpuUniformCudaHipRtIS5_St17integral_constantImLm1EEjEES8_jJN4reco13ZVertexLayoutILm128ELb0EE22ViewTemplateFreeParamsILm128ELb0ELb1ELb1EEENSA_19ZVertexTracksLayoutILm128ELb0EE22ViewTemplateFreeParamsILm128ELb0ELb1ELb1EEEN12vertexFinder22PixelVertexWSSoALayoutILm128ELb0EE22ViewTemplateFreeParamsILm128ELb0ELb1ELb1EEEEEEvNS_3VecIT2_T3_EET_DpT4_' uses too much shared data (0xfdb0 bytes, 0xc000 max) (target: sm_60) nvlink error : Entry function '_ZN6alpaka6detail9gpuKernelIN17alpaka_cuda_async12vertexFinder19SplitVerticesKernelENS_9ApiCudaRtENS_22AccGpuUniformCudaHipRtIS5_St17integral_constantImLm1EEjEES8_jJN4reco13ZVertexLayoutILm128ELb0EE22ViewTemplateFreeParamsILm128ELb0ELb1ELb1EEENSA_19ZVertexTracksLayoutILm128ELb0EE22ViewTemplateFreeParamsILm128ELb0ELb1ELb1EEEN12vertexFinder22PixelVertexWSSoALayoutILm128ELb0EE22ViewTemplateFreeParamsILm128ELb0ELb1ELb1EEEfEEEvNS_3VecIT2_T3_EET_DpT4_' uses too much shared data (0xfdac bytes, 0xc000 max) (target: sm_60) nvlink error : Entry function '_ZN6alpaka6detail9gpuKernelIN17alpaka_cuda_async12vertexFinder28ClusterTracksByDensityKernelENS_9ApiCudaRtENS_22AccGpuUniformCudaHipRtIS5_St17integral_constantImLm1EEjEES8_jJN4reco13ZVertexLayoutILm128ELb0EE22ViewTemplateFreeParamsILm128ELb0ELb1ELb1EEENSA_19ZVertexTracksLayoutILm128ELb0EE22ViewTemplateFreeParamsILm128ELb0ELb1ELb1EEEN12vertexFinder22PixelVertexWSSoALayoutILm128ELb0EE22ViewTemplateFreeParamsILm128ELb0ELb1ELb1EEEifffEEEvNS_3VecIT2_T3_EET_DpT4_' uses too much shared data (0xfda8 bytes, 0xc000 max) (target: sm_60) nvlink error : Entry function '_ZN6alpaka6detail9gpuKernelIN17alpaka_cuda_async12vertexFinder21VertexFinderOneKernelENS_9ApiCudaRtENS_22AccGpuUniformCudaHipRtIS5_St17integral_constantImLm1EEjEES8_jJN4reco13ZVertexLayoutILm128ELb0EE22ViewTemplateFreeParamsILm128ELb0ELb1ELb1EEENSA_19ZVertexTracksLayoutILm128ELb0EE22ViewTemplateFreeParamsILm128ELb0ELb1ELb1EEEN12vertexFinder22PixelVertexWSSoALayoutILm128ELb0EE22ViewTemplateFreeParamsILm128ELb0ELb1ELb1EEEbifffEEEvNS_3VecIT2_T3_EET_DpT4_' uses too much shared data (0xfdb0 bytes, 0xc000 max) (target: sm_60) gmake: *** [tmp/el8_amd64_gcc12/src/RecoVertex/PixelVertexFinding/plugins/RecoPixelVertexingPixelVertexFindingPluginsPortableCudaAsync/RecoPixelVertexingPixelVertexFindingPluginsPortableCudaAsync_cudadlink.o] Error 255 >> Building alpaka/cuda edm plugin tmp/el8_amd64_gcc12/src/RecoVertex/PixelVertexFinding/plugins/RecoPixelVertexingPixelVertexFindingPluginsPortableCudaAsync/libRecoPixelVertexingPixelVertexFindingPluginsPortableCudaAsync.so /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02874/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/bin/c++ -O3 -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++20 -ftree-vectorize -Werror=array-bounds -Werror=format-contains-nul -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -Wno-error=array-bounds -Warray-bounds -fuse-ld=bfd -march=x86-64-v3 -felide-constructors -fmessage-length=0 -Wall -Wno-non-template-friend -Wno-long-long -Wreturn-type -Wextra -Wpessimizing-move -Wclass-memaccess -Wno-cast-function-type -Wno-unused-but-set-parameter -Wno-ignored-qualifiers -Wno-unused-parameter -Wunused -Wparentheses -Werror=return-type -Werror=missing-braces -Werror=unused-value -Werror=unused-label -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=unused-but-set-variable -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=return-local-addr -Wnon-virtual-dtor -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-psabi -DEIGEN_DONT_PARALLELIZE -DEIGEN_MAX_ALIGN_BYTES=64 -Wno-error=unused-variable -DALPAKA_DEFAULT_HOST_MEMORY_ALIGNMENT=128 -DALPAKA_DISABLE_VENDOR_RNG -DALPAKA_ACC_GPU_CUDA_ENABLED -DALPAKA_ACC_GPU_CUDA_ONLY_MODE -DALPAKA_HOST_ONLY -DBOOST_DISABLE_ASSERTS -flto=auto -fipa-icf -flto-odr-type-merging -fno-fat-lto-objects -Wodr -shared -Wl,-E -Wl,-z,defs tmp/el8_amd64_gcc12/src/RecoVertex/PixelVertexFinding/plugins/RecoPixelVertexingPixelVertexFindingPluginsPortableCudaAsync/alpaka/PixelVertexProducerAlpaka.cc.o tmp/el8_amd64_gcc12/src/RecoVertex/PixelVertexFinding/plugins/RecoPixelVertexingPixelVertexFindingPluginsPortableCudaAsync/alpaka/vertexFinder.dev.cc.o tmp/el8_amd64_gcc12/src/RecoVertex/PixelVertexFinding/plugins/RecoPixelVertexingPixelVertexFindingPluginsPortableCudaAsync/RecoPixelVertexingPixelVertexFindingPluginsPortableCudaAsync_cudadlink.o -o tmp/el8_amd64_gcc12/src/RecoVertex/PixelVertexFinding/plugins/RecoPixelVertexingPixelVertexFindingPluginsPortableCudaAsync/libRecoPixelVertexingPixelVertexFindingPluginsPortableCudaAsync.so -Wl,-E -Wl,--hash-style=gnu -Wl,--as-needed -Wl,-z,noexecstack -L/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_15_0_X_2025-01-29-2300/biglib/el8_amd64_gcc12 -L/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_15_0_X_2025-01-29-2300/lib/el8_amd64_gcc12 -L/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02874/el8_amd64_gcc12/cms/cmssw/CMSSW_15_0_X_2025-01-29-2300/biglib/el8_amd64_gcc12 -L/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02874/el8_amd64_gcc12/cms/cmssw/CMSSW_15_0_X_2025-01-29-2300/lib/el8_amd64_gcc12 -L/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02874/el8_amd64_gcc12/cms/cmssw/CMSSW_15_0_X_2025-01-29-2300/external/el8_amd64_gcc12/lib -L/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02874/el8_amd64_gcc12/external/cuda/12.8.0-15bfa86985d46d842bb5ecc3aca6c676/lib64/stubs -L/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_15_0_X_2025-01-29-2300/static/el8_amd64_gcc12 -L/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02874/el8_amd64_gcc12/cms/cmssw/CMSSW_15_0_X_2025-01-29-2300/static/el8_amd64_gcc12 -lDataFormatsJetReco -lDataFormatsParticleFlowCandidate -lDataFormatsParticleFlowReco -lDataFormatsEgammaCandidates -lDataFormatsMuonReco -lRecoLocalTrackerClusterParameterEstimatorCudaAsync -lDataFormatsRecoCandidate -lRecoLocalTrackerClusterParameterEstimator -lRecoVertexPixelVertexFinding -lDataFormatsEgammaReco -lDataFormatsGsfTrackReco -lDataFormatsVertexReco -lTrackingToolsTrajectoryState -lDataFormatsTrackReco -lDataFormatsGEMRecHit -lDataFormatsTrackCandidate -lDataFormatsTrackerRecHit2D -lDataFormatsCSCRecHit -lDataFormatsDTRecHit -lDataFormatsFTLRecHit -lDataFormatsTrajectorySeed -lRecoLocalTrackerRecords -lCalibTrackerRecords -lDataFormatsTrackingRecHit -lGeometryTrackerGeometryBuilder -lDataFormatsL1TrackTrigger -lMagneticFieldRecords -lCommonToolsClustering1D -lCondFormatsDataRecord -lDataFormatsBeamSpotCudaAsync -lDataFormatsTrackerCommon -lGeometryCaloGeometry -lGeometryCommonTopologies -lDataFormatsBeamSpot -lDataFormatsCaloTowers -lDataFormatsEcalRecHit -lDataFormatsGeometryCommonDetAlgo -lDataFormatsHepMCCandidate -lDataFormatsSiStripCluster -lGeometryRecords -lGeometryTrackerNumberingBuilder -lHeterogeneousCoreAlpakaCoreCudaAsync -lTrackingToolsAnalyticalJacobians -lCondFormatsAlignmentRecord -lDataFormatsCandidate -lDataFormatsDTDigi -lDataFormatsEcalDigi -lDataFormatsGeometrySurface -lDataFormatsTrajectoryState -lDetectorDescriptionCore -lDetectorDescriptionDDCMS -lHeterogeneousCoreAlpakaCore -lMagneticFieldEngine -lCondFormatsGeometryObjects -lDataFormatsCLHEP -lDataFormatsCaloRecHit -lDataFormatsEcalDetId -lDataFormatsForwardDetId -lDataFormatsGeometryVector -lDataFormatsHcalDetId -lDataFormatsMuonDetId -lDataFormatsPhase2TrackerCluster -lDataFormatsSiPixelDetId -lDataFormatsSiStripDetId -lDataFormatsTrackSoACudaAsync -lDataFormatsVertexSoACudaAsync -lFWCoreFramework -lSimDataFormatsPileupSummaryInfo -lDataFormatsDetId -lDataFormatsFEDRawData -lDataFormatsMath -lDataFormatsPhase2TrackerDigi -lDataFormatsScouting -lDataFormatsSiPixelCluster -lDataFormatsSiStripDigi -lDataFormatsTrackSoA -lDataFormatsVertexSoA -lFWCoreCommon -lFWCoreServiceRegistry -lDataFormatsCommon -lFWCoreParameterSet -lFWCoreMessageLogger -lDataFormatsProvenance -lFWCoreConcurrency -lFWCorePluginManager -lFWCoreReflection -lHeterogeneousCoreAlpakaInterface -lTrackingToolsTrajectoryParametrization -lCondFormatsSerialization -lFWCoreUtilities -lFWCoreVersion -lDDAlign -lDDCond -lDDCore -lDDParsers -lPhysics -lHist -lMatrix -lGenVector -lMathMore -lTree -lNet -lGeom -lThread -lMathCore -lRIO -lSmatrix -lboost_program_options -lboost_serialization -lCore -lboost_thread -lboost_date_time -lCLHEP -lHepMCfio -lHepMC -lpcre -lbz2 -lcudart -lcudadevrt -lnvToolsExt -lgsl -luuid -ltbb -lxerces-c -llzma -lz -lcuda -lfmt -lcms-md5 -lopenblas -lcrypt -ldl -lrt -lstdc++fs -ltinyxml2 /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02874/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/bin/../lib/gcc/x86_64-redhat-linux-gnu/12.3.1/../../../../x86_64-redhat-linux-gnu/bin/ld.bfd: cannot find tmp/el8_amd64_gcc12/src/RecoVertex/PixelVertexFinding/plugins/RecoPixelVertexingPixelVertexFindingPluginsPortableCudaAsync/RecoPixelVertexingPixelVertexFindingPluginsPortableCudaAsync_cudadlink.o: No such file or directory collect2: error: ld returned 1 exit status gmake: *** [tmp/el8_amd64_gcc12/src/RecoVertex/PixelVertexFinding/plugins/RecoPixelVertexingPixelVertexFindingPluginsPortableCudaAsync/libRecoPixelVertexingPixelVertexFindingPluginsPortableCudaAsync.so] Error 1 |
| // enable_if should be used when there is another implementation, | ||
| // please use static_assert to report invalid template arguments |
There was a problem hiding this comment.
I guess we disagree on how to write C++ code.
|
-heterogeneous |
| @@ -57,11 +57,12 @@ | |||
| # 2024 with PU, Alpaka-based | |||
| 17034.402, 17034.403, 17034.404, | |||
| 17034.406, 17034.407, 17034.408, | |||
| 17034.409, | |||
There was a problem hiding this comment.
please follow the existing numbering scheme, and introduce workflows for
- regular reconstruction
- GPU vs CPU validation
- profiling
|
|
||
|
|
| @@ -4,12 +4,12 @@ | |||
| #include <cstdint> | |||
|
|
|||
| #include <alpaka/alpaka.hpp> | |||
|
|
|||
There was a problem hiding this comment.
please add back the empty line
| @@ -140,6 +140,7 @@ namespace pixelTrack { | |||
|
|
|||
| float pt = std::min<float>(tracks.pt(it), chi2MaxPt); | |||
| float chi2Cut = chi2Scale * (chi2Coeff[0] + roughLog(pt) * chi2Coeff[1]); | |||
| //chi2Cut = chi2Scale; | |||
There was a problem hiding this comment.
what does this comment mean ?
| @@ -13,4 +13,9 @@ | |||
| <class name="alpaka_rocm_async::pixelTrack::TracksSoACollectionPhase2" persistent="false"/> | |||
| <class name="edm::DeviceProduct<alpaka_rocm_async::pixelTrack::TracksSoACollectionPhase2>" persistent="false"/> | |||
| <class name="edm::Wrapper<edm::DeviceProduct<alpaka_rocm_async::pixelTrack::TracksSoACollectionPhase2>>" persistent="false"/> | |||
|
|
|||
| <class name="alpaka_rocm_async::PortableCollection<reco::TrackLayout<pixelTopology::Phase1Strip>>" persistent="false"/> | |||
| constexpr int nPairs = 13 + 2 + 4; | ||
| ; // without jump + jumping barrel + jumping forward |
| 3716, // Np | ||
| numberOfModules}; | ||
|
|
||
| static constexpr uint32_t layerStart[numberOfLayers + 1] = {0, |
There was a problem hiding this comment.
mhmh, why no longer HOST_DEVICE_CONSTANT ?
if layerStart no longer used in device code ?
| @@ -378,7 +386,9 @@ namespace pixelTopology { | |||
| static constexpr int maxDYsize = 10; | |||
| static constexpr int maxDYPred = 20; | |||
|
|
|||
| static constexpr uint16_t numberOfModules = phase2PixelTopology::numberOfModules; | |||
| static constexpr uint16_t numberOfModules = 3892; | |||
There was a problem hiding this comment.
please take these "magic" numbers from an existing definition
| }; | ||
|
|
||
| struct Phase1 { | ||
| // types | ||
| using hindex_type = uint32_t; // FIXME from siPixelRecHitsHeterogeneousProduct | ||
| using tindex_type = uint16_t; // for tuples | ||
| using tindex_type = uint32_t; // for tuples |
| @@ -475,7 +490,9 @@ namespace pixelTopology { | |||
| static constexpr int maxDYsize = 20; | |||
| static constexpr int maxDYPred = 20; | |||
|
|
|||
| static constexpr uint16_t numberOfModules = phase1PixelTopology::numberOfModules; | |||
| static constexpr uint16_t numberOfModules = 1856; | |||
| static constexpr int minYsizeB1 = 1; | ||
| static constexpr int minYsizeB2 = 1; |
| @@ -0,0 +1,293 @@ | |||
| #ifndef Geometry_CommonTopologies_SimpleSeedingLayersTopology_h | |||
| #define Geometry_CommonTopologies_SimpleSeedingLayersTopology_h | |||
| #include <iostream> | |||
| #include <alpaka/alpaka.hpp> | ||
| #include "HeterogeneousCore/AlpakaInterface/interface/CopyToDevice.h" | ||
| #include "HeterogeneousCore/AlpakaInterface/interface/config.h" | ||
| #include "HeterogeneousCore/AlpakaInterface/interface/memory.h" | ||
| #include "DataFormats/GeometrySurface/interface/SOARotation.h" | ||
|
|
||
| #include "DataFormats/SoATemplate/interface/SoALayout.h" |
There was a problem hiding this comment.
| #include <alpaka/alpaka.hpp> | |
| #include "HeterogeneousCore/AlpakaInterface/interface/CopyToDevice.h" | |
| #include "HeterogeneousCore/AlpakaInterface/interface/config.h" | |
| #include "HeterogeneousCore/AlpakaInterface/interface/memory.h" | |
| #include "DataFormats/GeometrySurface/interface/SOARotation.h" | |
| #include "DataFormats/SoATemplate/interface/SoALayout.h" | |
| #include "DataFormats/GeometrySurface/interface/SOARotation.h" | |
| #include "DataFormats/SoATemplate/interface/SoALayout.h" |
| namespace cms::alpakatools { | ||
| template <> | ||
| struct CopyToDevice<FrameSoAHost> { | ||
| template <typename TQueue> | ||
| static auto copyAsync(TQueue& queue, FrameSoAHost const& srcData) { | ||
| using TDevice = typename alpaka::trait::DevType<TQueue>::type; | ||
| FrameSoADevice<TDevice> dstData(srcData->metadata().size(), queue); | ||
| alpaka::memcpy(queue, dstData.buffer(), srcData.buffer()); | ||
| return dstData; | ||
| } | ||
| }; | ||
| } // namespace cms::alpakatools |
There was a problem hiding this comment.
This should no be necessary, as CopyToDevice is already available for PortableCollection specialisations.
There was a problem hiding this comment.
If I remove this piece I get issues in FrameSoAESProducer, could you suggest me how to proceed?: ```
/cvmfs/cms-ib.cern.ch/sw/x86_64/week0/el8_amd64_gcc12/cms/cmssw/CMSSW_15_0_DEVEL_X_2025-01-28-2300/src/HeterogeneousCore/AlpakaCore/interface/alpaka/ESProducer.h: In instantiation of 'auto alpaka_rocm_async::ESProducer::setWhatProduced(T*, TReturn (T::)(const TRecord&), const edm::es::Label&) [with T = alpaka_rocm_async::FrameSoAESProducerpixelTopology::Phase2; TReturn = std::unique_ptr<PortableHostCollection<FrameLayout<> > >; TRecord = FrameSoARecord]':
/cvmfs/cms-ib.cern.ch/sw/x86_64/week0/el8_amd64_gcc12/cms/cmssw/CMSSW_15_0_DEVEL_X_2025-01-28-2300/src/HeterogeneousCore/AlpakaCore/interface/alpaka/ESProducer.h:41:29: required from 'auto alpaka_rocm_async::ESProducer::setWhatProduced(T, const edm::es::Label&) [with T = alpaka_rocm_async::FrameSoAESProducerpixelTopology::Phase2]'
src/RecoLocalTracker/ClusterParameterEstimator/plugins/alpaka/FrameSoAESProducer.cc:56:30: required from 'alpaka_rocm_async::FrameSoAESProducer::FrameSoAESProducer(const edm::ParameterSet&) [with TrackerTraits = pixelTopology::Phase2]'
/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02874/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/include/c++/12.3.1/bits/stl_construct.h:119:7: required from 'constexpr void std::_Construct(_Tp*, _Args&& ...) [with _Tp = alpaka_rocm_async::FrameSoAESProducerpixelTopology::Phase2; _Args = {edm::ParameterSet&}]'
/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02874/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/include/c++/12.3.1/bits/alloc_traits.h:635:19: required from 'static constexpr void std::allocator_traits<std::allocator >::construct(allocator_type&, _Up*, _Args&& ...) [with _Up = alpaka_rocm_async::FrameSoAESProducerpixelTopology::Phase2; _Args = {edm::ParameterSet&}; allocator_type = std::allocator]'
/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02874/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/include/c++/12.3.1/bits/shared_ptr_base.h:604:39: required from 'std::_Sp_counted_ptr_inplace<_Tp, _Alloc, _Lp>::_Sp_counted_ptr_inplace(_Alloc, _Args&& ...) [with _Args = {edm::ParameterSet&}; _Tp = alpaka_rocm_async::FrameSoAESProducerpixelTopology::Phase2; _Alloc = std::allocator; __gnu_cxx::_Lock_policy _Lp = __gnu_cxx::_S_atomic]'
/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02874/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/include/c++/12.3.1/bits/shared_ptr_base.h:971:16: required from 'std::__shared_count<_Lp>::__shared_count(_Tp*&, std::_Sp_alloc_shared_tag<_Alloc>, _Args&& ...) [with _Tp = alpaka_rocm_async::FrameSoAESProducerpixelTopology::Phase2; _Alloc = std::allocator; _Args = {edm::ParameterSet&}; __gnu_cxx::_Lock_policy _Lp = __gnu_cxx::_S_atomic]'
/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02874/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/include/c++/12.3.1/bits/shared_ptr_base.h:1712:14: required from 'std::__shared_ptr<_Tp, _Lp>::__shared_ptr(std::_Sp_alloc_shared_tag<_Tp>, _Args&& ...) [with _Alloc = std::allocator; _Args = {edm::ParameterSet&}; _Tp = alpaka_rocm_async::FrameSoAESProducerpixelTopology::Phase2; __gnu_cxx::_Lock_policy _Lp = __gnu_cxx::_S_atomic]'
/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02874/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/include/c++/12.3.1/bits/shared_ptr.h:464:59: required from 'std::shared_ptr<_Tp>::shared_ptr(std::_Sp_alloc_shared_tag<_Tp>, _Args&& ...) [with _Alloc = std::allocator; _Args = {edm::ParameterSet&}; _Tp = alpaka_rocm_async::FrameSoAESProducerpixelTopology::Phase2]'
/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02874/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/include/c++/12.3.1/bits/shared_ptr.h:1009:14: required from 'std::shared_ptr<std::_NonArray<_Tp> > std::make_shared(_Args&& ...) [with _Tp = alpaka_rocm_async::FrameSoAESProducerpixelTopology::Phase2; _Args = {edm::ParameterSet&}; _NonArray<_Tp> = alpaka_rocm_async::FrameSoAESProducerpixelTopology::Phase2]'
/cvmfs/cms-ib.cern.ch/sw/x86_64/week0/el8_amd64_gcc12/cms/cmssw/CMSSW_15_0_DEVEL_X_2025-01-28-2300/src/FWCore/Framework/interface/ComponentMaker.h:139:75: required from 'std::shared_ptr edm::eventsetup::ComponentMaker<T, TComponent>::addTo(edm::eventsetup::EventSetupsController&, edm::eventsetup::EventSetupProvider&, edm::ParameterSet&, bool) const [with T = edm::eventsetup::ModuleMakerTraits; TComponent = alpaka_rocm_async::FrameSoAESProducerpixelTopology::Phase2; typename T::base_type = edm::eventsetup::ESProductResolverProvider]'
/cvmfs/cms-ib.cern.ch/sw/x86_64/week0/el8_amd64_gcc12/cms/cmssw/CMSSW_15_0_DEVEL_X_2025-01-28-2300/src/FWCore/Framework/interface/ComponentMaker.h:96:72: required from here
/cvmfs/cms-ib.cern.ch/sw/x86_64/week0/el8_amd64_gcc12/cms/cmssw/CMSSW_15_0_DEVEL_X_2025-01-28-2300/src/HeterogeneousCore/AlpakaCore/interface/alpaka/ESProducer.h:56:54: error: incomplete type 'CopyT' {aka 'cms::alpakatools::CopyToDevice<PortableHostCollection<FrameLayout<> > >'} used in nested name specifier
56 | return std::optional{CopyT::copyAsync(iRecord.queue(), handle)};
| ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~
/cvmfs/cms-ib.cern.ch/sw/x86_64/week0/el8_amd64_gcc12/cms/cmssw/CMSSW_15_0_DEVEL_X_2025-01-28-2300/src/HeterogeneousCore/AlpakaCore/interface/alpaka/ESProducer.h:58:63: error: incomplete type 'cms::alpakatools::CopyToDevice<PortableHostCollection<FrameLayout<> > >' used in nested name specifier
58 | return std::optional<decltype(CopyT::copyAsync(std::declval<Queue&>(), std::declval()))>();
| ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/cvmfs/cms-ib.cern.ch/sw/x86_64/week0/el8_amd64_gcc12/cms/cmssw/CMSSW_15_0_DEVEL_X_2025-01-28-2300/src/FWCore/Framework/interface/es_impl/ReturnArgumentTypes.h: In instantiation of 'struct edm::eventsetup::impl::ReturnArgumentTypes<alpaka_rocm_async::ESProducer::setWhatProduced<alpaka_rocm_async::FrameSoAESProducerpixelTopology::Phase2, std::unique_ptr<PortableHostCollection<FrameLayout<> > >, FrameSoARecord>(alpaka_rocm_async::FrameSoAESProducerpixelTopology::Phase2, std::unique_ptr<PortableHostCollection<FrameLayout<> > > (alpaka_rocm_async::FrameSoAESProducerpixelTopology::Phase2::)(const FrameSoARecord&), const edm::es::Label&)::<lambda(const alpaka_rocm_async::device::Record&)> >':
/cvmfs/cms-ib.cern.ch/sw/x86_64/week0/el8_amd64_gcc12/cms/cmssw/CMSSW_15_0_DEVEL_X_2025-01-28-2300/src/HeterogeneousCore/AlpakaCore/interface/alpaka/ESProducer.h:96:13: required from 'auto alpaka_rocm_async::ESProducer::setWhatProducedDevice(TFunc&&, const edm::es::Label&) [with TRecord = FrameSoARecord; TFunc = alpaka_rocm_async::ESProducer::setWhatProduced<alpaka_rocm_async::FrameSoAESProducerpixelTopology::Phase2, std::unique_ptr<PortableHostCollection<FrameLayout<> > >, FrameSoARecord>(alpaka_rocm_async::FrameSoAESProducerpixelTopology::Phase2, std::unique_ptr<PortableHostCollection<FrameLayout<> > > (alpaka_rocm_async::FrameSoAESProducerpixelTopology::Phase2::)(const FrameSoARecord&), const edm::es::Label&)::<lambda(const alpaka_rocm_async::device::Record&)>]'
/cvmfs/cms-ib.cern.ch/sw/x86_64/week0/el8_amd64_gcc12/cms/cmssw/CMSSW_15_0_DEVEL_X_2025-01-28-2300/src/HeterogeneousCore/AlpakaCore/interface/alpaka/ESProducer.h:51:52: required from 'auto alpaka_rocm_async::ESProducer::setWhatProduced(T, TReturn (T::)(const TRecord&), const edm::es::Label&) [with T = alpaka_rocm_async::FrameSoAESProducerpixelTopology::Phase2; TReturn = std::unique_ptr<PortableHostCollection<FrameLayout<> > >; TRecord = FrameSoARecord]'
/cvmfs/cms-ib.cern.ch/sw/x86_64/week0/el8_amd64_gcc12/cms/cmssw/CMSSW_15_0_DEVEL_X_2025-01-28-2300/src/HeterogeneousCore/AlpakaCore/interface/alpaka/ESProducer.h:41:29: required from 'auto alpaka_rocm_async::ESProducer::setWhatProduced(T, const edm::es::Label&) [with T = alpaka_rocm_async::FrameSoAESProducerpixelTopology::Phase2]'
src/RecoLocalTracker/ClusterParameterEstimator/plugins/alpaka/FrameSoAESProducer.cc:56:30: required from 'alpaka_rocm_async::FrameSoAESProducer::FrameSoAESProducer(const edm::ParameterSet&) [with TrackerTraits = pixelTopology::Phase2]'
/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02874/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/include/c++/12.3.1/bits/stl_construct.h:119:7: required from 'constexpr void std::_Construct(_Tp*, _Args&& ...) [with _Tp = alpaka_rocm_async::FrameSoAESProducerpixelTopology::Phase2; _Args = {edm::ParameterSet&}]'
/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02874/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/include/c++/12.3.1/bits/alloc_traits.h:635:19: [ skipping 2 instantiation contexts, use -ftemplate-backtrace-limit=0 to disable ]
/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02874/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/include/c++/12.3.1/bits/shared_ptr_base.h:971:16: required from 'std::__shared_count<_Lp>::__shared_count(_Tp*&, std::_Sp_alloc_shared_tag<_Alloc>, _Args&& ...) [with _Tp = alpaka_rocm_async::FrameSoAESProducerpixelTopology::Phase2; _Alloc = std::allocator; _Args = {edm::ParameterSet&}; __gnu_cxx::_Lock_policy _Lp = __gnu_cxx::_S_atomic]'
/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02874/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/include/c++/12.3.1/bits/shared_ptr_base.h:1712:14: required from 'std::__shared_ptr<_Tp, _Lp>::__shared_ptr(std::_Sp_alloc_shared_tag<_Tp>, _Args&& ...) [with _Alloc = std::allocator; _Args = {edm::ParameterSet&}; _Tp = alpaka_rocm_async::FrameSoAESProducerpixelTopology::Phase2; __gnu_cxx::_Lock_policy _Lp = __gnu_cxx::_S_atomic]'
/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02874/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/include/c++/12.3.1/bits/shared_ptr.h:464:59: required from 'std::shared_ptr<_Tp>::shared_ptr(std::_Sp_alloc_shared_tag<_Tp>, _Args&& ...) [with _Alloc = std::allocator; _Args = {edm::ParameterSet&}; _Tp = alpaka_rocm_async::FrameSoAESProducerpixelTopology::Phase2]'
/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02874/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/include/c++/12.3.1/bits/shared_ptr.h:1009:14: required from 'std::shared_ptr<std::_NonArray<_Tp> > std::make_shared(_Args&& ...) [with _Tp = alpaka_rocm_async::FrameSoAESProducerpixelTopology::Phase2; _Args = {edm::ParameterSet&}; _NonArray<_Tp> = alpaka_rocm_async::FrameSoAESProducerpixelTopology::Phase2]'
/cvmfs/cms-ib.cern.ch/sw/x86_64/week0/el8_amd64_gcc12/cms/cmssw/CMSSW_15_0_DEVEL_X_2025-01-28-2300/src/FWCore/Framework/interface/ComponentMaker.h:139:75: required from 'std::shared_ptr edm::eventsetup::ComponentMaker<T, TComponent>::addTo(edm::eventsetup::EventSetupsController&, edm::eventsetup::EventSetupProvider&, edm::ParameterSet&, bool) const [with T = edm::eventsetup::ModuleMakerTraits; TComponent = alpaka_rocm_async::FrameSoAESProducerpixelTopology::Phase2; typename T::base_type = edm::eventsetup::ESProductResolverProvider]'
/cvmfs/cms-ib.cern.ch/sw/x86_64/week0/el8_amd64_gcc12/cms/cmssw/CMSSW_15_0_DEVEL_X_2025-01-28-2300/src/FWCore/Framework/interface/ComponentMaker.h:96:72: required from here
/cvmfs/cms-ib.cern.ch/sw/x86_64/week0/el8_amd64_gcc12/cms/cmssw/CMSSW_15_0_DEVEL_X_2025-01-28-2300/src/FWCore/Framework/interface/es_impl/ReturnArgumentTypes.h:55:13: error: invalid use of incomplete type 'struct edm::eventsetup::impl::ReturnArgumentTypesImpl<auto (alpaka_rocm_async::ESProducer::setWhatProduced<alpaka_rocm_async::FrameSoAESProducerpixelTopology::Phase2, std::unique_ptr<PortableHostCollection<FrameLayout<> > >, FrameSoARecord>(alpaka_rocm_async::FrameSoAESProducerpixelTopology::Phase2, std::unique_ptr<PortableHostCollection<FrameLayout<> > > (alpaka_rocm_async::FrameSoAESProducerpixelTopology::Phase2::)(const FrameSoARecord&), const edm::es::Label&)::<lambda(const alpaka_rocm_async::device::Record&)>::)(const alpaka_rocm_async::device::Record&) const>'
55 | using argument_type = typename ReturnArgumentTypesImpl<decltype(&F::operator())>::argument_type;
| ^~~~~~~~~~~~~
/cvmfs/cms-ib.cern.ch/sw/x86_64/week0/el8_amd64_gcc12/cms/cmssw/CMSSW_15_0_DEVEL_X_2025-01-28-2300/src/FWCore/Framework/interface/es_impl/ReturnArgumentTypes.h:9:12: note: declaration of 'struct edm::eventsetup::impl::ReturnArgumentTypesImpl<auto (alpaka_rocm_async::ESProducer::setWhatProduced<alpaka_rocm_async::FrameSoAESProducerpixelTopology::Phase2, std::unique_ptr<PortableHostCollection<FrameLayout<> > >, FrameSoARecord>(alpaka_rocm_async::FrameSoAESProducerpixelTopology::Phase2, std::unique_ptr<PortableHostCollection<FrameLayout<> > > (alpaka_rocm_async::FrameSoAESProducerpixelTopology::Phase2::)(const FrameSoARecord&), const edm::es::Label&)::<lambda(const alpaka_rocm_async::device::Record&)>::)(const alpaka_rocm_async::device::Record&) const>'
9 | struct ReturnArgumentTypesImpl;
| ^~~~~~~~~~~~~~~~~~~~~~~
/cvmfs/cms-ib.cern.ch/sw/x86_64/week0/el8_amd64_gcc12/cms/cmssw/CMSSW_15_0_DEVEL_X_2025-01-28-2300/src/FWCore/Framework/interface/es_impl/ReturnArgumentTypes.h:56:13: error: invalid use of incomplete type 'struct edm::eventsetup::impl::ReturnArgumentTypesImpl<auto (alpaka_rocm_async::ESProducer::setWhatProduced<alpaka_rocm_async::FrameSoAESProducerpixelTopology::Phase2, std::unique_ptr<PortableHostCollection<FrameLayout<> > >, FrameSoARecord>(alpaka_rocm_async::FrameSoAESProducerpixelTopology::Phase2, std::unique_ptr<PortableHostCollection<FrameLayout<> > > (alpaka_rocm_async::FrameSoAESProducerpixelTopology::Phase2::)(const FrameSoARecord&), const edm::es::Label&)::<lambda(const alpaka_rocm_async::device::Record&)>::)(const alpaka_rocm_async::device::Record&) const>'
56 | using return_type = typename ReturnArgumentTypesImpl<decltype(&F::operator())>::return_type;
| ^~~~~~~~~~~
/cvmfs/cms-ib.cern.ch/sw/x86_64/week0/el8_amd64_gcc12/cms/cmssw/CMSSW_15_0_DEVEL_X_2025-01-28-2300/src/FWCore/Framework/interface/es_impl/ReturnArgumentTypes.h:9:12: note: declaration of 'struct edm::eventsetup::impl::ReturnArgumentTypesImpl<auto (alpaka_rocm_async::ESProducer::setWhatProduced<alpaka_rocm_async::FrameSoAESProducerpixelTopology::Phase2, std::unique_ptr<PortableHostCollection<FrameLayout<> > >, FrameSoARecord>(alpaka_rocm_async::FrameSoAESProducerpixelTopology::Phase2, std::unique_ptr<PortableHostCollection<FrameLayout<> > > (alpaka_rocm_async::FrameSoAESProducerpixelTopology::Phase2::)(const FrameSoARecord&), const edm::es::Label&)::<lambda(const alpaka_rocm_async::device::Record&)>::)(const alpaka_rocm_async::device::Record&) const>'
9 | struct ReturnArgumentTypesImpl;
| ^~~~~~~~~~~~~~~~~~~~~~~
| namespace ALPAKA_ACCELERATOR_NAMESPACE { | ||
|
|
||
| template <typename TrackerTraits> | ||
| class SiStripRecHitSoA : public stream::SynchronizingEDProducer<> { |
There was a problem hiding this comment.
please rename this to SiStripRecHitSoAProducer
| static void fillDescriptions(edm::ConfigurationDescriptions& descriptions); | ||
|
|
||
| private: | ||
| void acquire(device::Event const& iEvent, device::EventSetup const& iSetup) override {}; |
There was a problem hiding this comment.
why do you use a SynchronizingEDProducer if you have an empty acquire method ?
| //std::cout << "nStripHits = " << nStripHits << std::endl; | ||
| //std::cout << "nPixelHits = " << nPixelHits << std::endl; | ||
|
|
||
| // HostView<const PixelHits, PixelHitsHost> pixelHitsHostView(pixelHits, iEvent.queue()); | ||
| // PixelHitsHost& pixelHitsHost = pixelHitsHostView.get(); | ||
| // PixelHitsHost pixelHitsHost(nPixelHits, iEvent.queue()); | ||
|
|
||
| // alpaka::memcpy(iEvent.queue(), pixelHitsHost.buffer(), pixelHits.buffer()); |
PR description:
This PR should introduce the usage of strips layers to the offline reco and HLT Cellular Automaton (CA) usage (work done in 15_0_0_pre1):
customizeHLTforAlpakaStripfor HLT andstripNTupletFitfor offline reco, final geometry (Geometry/CommonTopologies/interface/SimplePixelStripTopology.py) pairs is still work in progressminYsizeB1andminYsizeB2cuts + generalization ofKernel_simpleTripletCleanerTest on TTbar PU EOR3 TRK DPG v7:
http://uaf-3.t2.ucsd.edu/~bdanzi/plots_pixelsOnlyValidation_AllCases/plots_hlt_hltPixel/effandfakePtEtaPhi.png where results in blue and red are produced with a cleaned 14_2_0 CMSSW release while the black one comes along with this PR changes
PR validation:
Before submitting I was checking
cc @mmasciov @slava77
Work co-authored-by: @AdrianoDee Adriano Di Florio [email protected]