-
Notifications
You must be signed in to change notification settings - Fork 11
T/4: Add debounce mechanism. #65
Conversation
# Conflicts: # src/mentionui.js
Edge.... :( |
🤞 last fixes to the test were pushed - hopefully will be OK now. |
@Reinmar thanks for the insights. I've cleaned up the code a bit but still, some minor work is needed:
But if feel free to check the code again if you wish - I don't think that much will change :) |
@Mgsy Could you please re-check this PR as before? This should work the same - ie no errors, etc. The code was refactored but it looks like everything works as expected. @Reinmar So it is ready to review. The only thing that I've wanted to ask is should we expose events? I'm not sure if they are important to others. Right now they are documented but without much fuzz around them. |
# Conflicts: # package.json
# Conflicts: # package.json
@mlewand the PR is OK now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on all browsers, seems to work fine now 👍 |
Suggested merge commit message (convention)
Type: Add debounce mechanism for requesting a feed. Closes ckeditor/ckeditor5#4619.
Additional information
100ms
so if the feed callback promise resolves within 100-150ms it should still be perceived as "fast". - note that toolbar plugin is debounced to 200ms.