Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The panel jumps after clicking on an item when the marker is a link. #4661

Closed
jodator opened this issue May 22, 2019 · 5 comments
Closed

The panel jumps after clicking on an item when the marker is a link. #4661

jodator opened this issue May 22, 2019 · 5 comments
Labels
package:mention resolution:expired This issue was closed due to lack of feedback. status:stale type:bug This issue reports a buggy (incorrect) behavior.

Comments

@jodator
Copy link
Contributor

jodator commented May 22, 2019

Found by @Mgsy.
bug_cke5

My 2¢:
Kinda is - internally the marker to which UI panel is positioned is removed so as described I have to return position to something - here this is selection - better would be to skip such positions (https://github.com/ckeditor/ckeditor5-ui/issues/503). I can see that after a while the panel is positioned to link anyway.

Other possible fix is to change the marker management logic entirely. Do not ever remove the mention marker - only update it if need (but I'm not sure if such logic will be easy enough to implement as currently logic checks if marker exists on some occasions...

@mlewand
Copy link
Contributor

mlewand commented May 28, 2019

mention-link-jumping

@jodator is the above gif another test case for the same issue or is it a different thing?

TC:

  • Apply link
  • Insert a mention within it
  • Move selection outside of a link
  • Click on a mention within a link

@jodator
Copy link
Contributor Author

jodator commented May 28, 2019

@mlewand is there a mention instance or only @foobar (without mention)? If there is a mention attribute on text then the mention UI shouldn't pop up. In other case (text only) I think that this is a similar issue but a bit different as here mention UI should "win" - not the link UI.

I'm for similar but different: here there's a race between Link UI and Mention UI and one of them should always win - I'm not sure which one as this is selection change not typing. With typing the Mention UI is obsious winner.

@mlewand
Copy link
Contributor

mlewand commented May 28, 2019

It's plain text only. So same race here.

@mlewand mlewand transferred this issue from ckeditor/ckeditor5-mention Oct 9, 2019
@mlewand mlewand added this to the nice-to-have milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:mention labels Oct 9, 2019
@pomek pomek removed this from the nice-to-have milestone Feb 21, 2022
@CKEditorBot
Copy link
Collaborator

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

@CKEditorBot
Copy link
Collaborator

We've closed your issue due to inactivity over the last year. We understand that the issue may still be relevant. If so, feel free to open a new one (and link this issue to it).

@CKEditorBot CKEditorBot added the resolution:expired This issue was closed due to lack of feedback. label Nov 7, 2023
@CKEditorBot CKEditorBot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:mention resolution:expired This issue was closed due to lack of feedback. status:stale type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

No branches or pull requests

4 participants