Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

T/4: Add debounce mechanism. #65

Merged
merged 56 commits into from
Dec 18, 2019
Merged

T/4: Add debounce mechanism. #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
56 commits
Select commit Hold shift + click to select a range
c2f8a3e
Add basic dev node server for mentions.
jodator Apr 23, 2019
3e72ea5
Add manual test for server testing. Fix CORS issues.
jodator Apr 23, 2019
0e94874
Add user database.
jodator Apr 24, 2019
8abfa24
Return entries from database.
jodator Apr 24, 2019
f11d317
Update mention ui display algorithm.
jodator Apr 24, 2019
aad2008
Merge branch 'master' into t/4
jodator Apr 24, 2019
c6d0d16
Merge branch 't/27' into t/4
jodator Apr 24, 2019
c2abd8c
Update the manual test visual appearance and add cache mechanism.
jodator Apr 24, 2019
c5e02b9
Add cache switch.
jodator Apr 24, 2019
520a709
Update dev-server timeouts.
jodator May 7, 2019
81993e0
Merge branch 'master' into t/4
jodator May 7, 2019
9b23fb1
Move dev-server to tests/_utils/asyncserver
jodator May 7, 2019
1047fb1
Add debounce mechanism to requesting for mention feed.
jodator May 7, 2019
aca45ab
Add test for debouncing Mention UI.
jodator May 8, 2019
62171d0
Typo fix.
jodator May 9, 2019
0385c8a
Show notification on failed feed callback call.
jodator May 9, 2019
e16eed3
Remove private debounced method.
jodator May 9, 2019
7f2e75f
Add internal docs to MentionUI.
jodator May 9, 2019
17c0871
Add tests description to anync mention feed manual tests.
jodator May 9, 2019
3b5b930
Add missing dependencies.
jodator May 9, 2019
dfe0a6b
Increase timeout in mention ui test
jodator May 9, 2019
3557476
Change the timeout in mention ui test
jodator May 9, 2019
fce8871
Increase waitForDebounce timeout in tests.
jodator May 9, 2019
0ebb287
Fix the out-of-order feeds callback times test.
jodator May 9, 2019
906df22
Add table toolbar configuration to mention manual tests.
jodator May 17, 2019
c1935e6
Fix usage of markers.
jodator May 17, 2019
eea0df0
Make requesting feed debounced rather then event listener.
jodator May 17, 2019
bf1d52e
Use newest marker in targe() callback.
jodator May 17, 2019
5d11ee9
Fix mention ui integration with other contextual balloons.
jodator May 20, 2019
063a137
Hide panel on matched text inside other mention when UI is still wait…
jodator May 21, 2019
76b1067
Fix balloon position target function to not operate on graveyard ranges.
jodator May 21, 2019
9e2e8f3
Add missing dependencies.
jodator May 22, 2019
711ebba
Merge branch 'master' into t/4
jodator May 27, 2019
80200f5
Log warning instead of showing notification when feed callback throws…
jodator May 29, 2019
27ed655
Merge branch 'master' into t/4
jodator Jun 25, 2019
7138841
Re-add missing dependency.
jodator Jun 25, 2019
f5768fe
Merge branch 'master' into t/4
jodator Jun 28, 2019
1a3e106
Merge branch 'master' into t/4
jodator Jul 22, 2019
d71103e
Merge branch 'master' into t/4
jodator Jul 25, 2019
699b580
Try to use events for UI display.
jodator Jul 25, 2019
e249ff8
Fix tests.
jodator Jul 25, 2019
06a4411
Extract _handleFeedResponse().
jodator Jul 25, 2019
46d18a1
Minor refactoring of the MentionUI.
jodator Jul 25, 2019
784fde6
Refactor & add internal documentation to MentionUI.
jodator Jul 25, 2019
5bb82ca
Add test for updating a marker on selection change.
jodator Jul 26, 2019
9798662
Update some conditional statements semantics.
jodator Jul 26, 2019
ef9085b
Move handledKeyCodes to module scope.
jodator Jul 26, 2019
4f6625d
Document MentionUI events.
jodator Jul 26, 2019
c7a481a
Fix MentionUI events params.
jodator Jul 26, 2019
b1bb2ba
Fix MentionUI event requestFeed:error params.
jodator Jul 26, 2019
9dee878
Add tests for events.
jodator Jul 26, 2019
bd17182
Merge branch 'master' into t/4
jodator Aug 26, 2019
2e421e9
Merge branch 'master' into t/4
jodator Dec 16, 2019
5420fac
Docs: No need to duplicate method name if it can be determined during…
mlewand Dec 18, 2019
80d29f9
Docs: Minor API docs corrections.
mlewand Dec 18, 2019
f677cd9
Internal: Make sure error contains a link to error code description.
mlewand Dec 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@
"@ckeditor/ckeditor5-core": "^16.0.0",
"@ckeditor/ckeditor5-ui": "^16.0.0",
"@ckeditor/ckeditor5-typing": "^16.0.0",
"@ckeditor/ckeditor5-utils": "^16.0.0"
"@ckeditor/ckeditor5-utils": "^16.0.0",
"lodash-es": "^4.17.10"
},
"devDependencies": {
"@ckeditor/ckeditor5-basic-styles": "^16.0.0",
Expand All @@ -31,6 +32,7 @@
"eslint-config-ckeditor5": "^2.0.0",
"husky": "^1.3.1",
"lint-staged": "^7.0.0",
"lodash": "^4.17.11",
"stylelint": "^11.1.1",
"stylelint-config-ckeditor5": "^1.0.0"
},
Expand Down
2 changes: 1 addition & 1 deletion src/mentionediting.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ export function _addMentionAttributes( baseMentionData, data ) {
* @protected
* @param {module:engine/view/element~Element} viewElementOrMention
* @param {String|Object} [data] Mention data to be extended.
* @return {module:mention/mention~MentionAttribute}
* @returns {module:mention/mention~MentionAttribute}
*/
export function _toMentionAttribute( viewElementOrMention, data ) {
const dataMention = viewElementOrMention.getAttribute( 'data-mention' );
Expand Down
Loading