Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make contextual balloon panel view skip empty targets #5510

Closed
jodator opened this issue May 21, 2019 · 2 comments
Closed

Make contextual balloon panel view skip empty targets #5510

jodator opened this issue May 21, 2019 · 2 comments
Labels
package:ui resolution:expired This issue was closed due to lack of feedback. status:stale type:bug This issue reports a buggy (incorrect) behavior.

Comments

@jodator
Copy link
Contributor

jodator commented May 21, 2019

I've been struggling with some errors on removing a panel from contextual balloon.

The issue is that when a view is removed from the balloon, the balloon uses old position to display new panel in the same placement as removed one. This works well if position target is static. When there's callback used the callback may operate on removed data - ie something that is not available in the view and doesn't have anything to point. It would be nice to return null or undefined from target() callback so the balloon plugin would use new position to display such element. Right now it uses the last one: https://github.com/ckeditor/ckeditor5-ui/blob/b34e9d553d70997551310cee531f95b69f88de5b/src/panel/balloon/contextualballoon.js#L425

while the view is removed from the stack later:
https://github.com/ckeditor/ckeditor5-ui/blob/b34e9d553d70997551310cee531f95b69f88de5b/src/panel/balloon/contextualballoon.js#L236-L247

Also the problem was that both panels were removed but the logic for updating balloon position was called for both removed panels.

@mlewand mlewand transferred this issue from ckeditor/ckeditor5-ui Oct 9, 2019
@mlewand mlewand added this to the backlog milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:ui labels Oct 9, 2019
@pomek pomek removed this from the backlog milestone Feb 21, 2022
@CKEditorBot
Copy link
Collaborator

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

@CKEditorBot
Copy link
Collaborator

We've closed your issue due to inactivity over the last year. We understand that the issue may still be relevant. If so, feel free to open a new one (and link this issue to it).

@CKEditorBot CKEditorBot added the resolution:expired This issue was closed due to lack of feedback. label Nov 7, 2023
@CKEditorBot CKEditorBot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:ui resolution:expired This issue was closed due to lack of feedback. status:stale type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

No branches or pull requests

4 participants