Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environments List search bar changes #4705

Closed
wants to merge 35 commits into from

Conversation

chaitali-mane
Copy link
Contributor

@chaitali-mane chaitali-mane commented Feb 8, 2021

🔩 Description: What code changed, and why?

Need to add the search bar for Environments List

⛓️ Related Resources

#4668

👍 Definition of Done

I have added the search bar for Environments list.

👟 How to Build and Test the Change

STEP 1
inside the hab studio

[default:/src:0]# build components/automate-ui-devproxy/
[default:/src:0]# start_automate_ui_background
[default:/src:0]# start_all_services

STEP 2
open new window
go to automate UI path

$ cd components/automate-ui
and run the command

npm run serve:hab

To add data https://github.com/chef/automate/blob/master/dev-docs/adding-data/adding_test_data.md#adding-data-to-infra-views
Go to Infrastructure tab >> Chef Servers it's under Chef-Server feature flag >> click to any server >> see the list of org's >> click to any org >> on org details page you can see the multiple tabs >> click to Environments tabs >> you can see the list of Environments

✅ Checklist

📷 Screenshots, if applicable

Environments search
env-seach

Environments search value
env-search-working

No data found in Environments search
env-search-no-data

@netlify
Copy link

netlify bot commented Feb 8, 2021

Deploy preview for chef-automate processing.

Building with commit a65770f

https://app.netlify.com/sites/chef-automate/deploys/60269158489d5400081306e9

@vinay033 vinay033 self-requested a review February 8, 2021 13:22
Copy link
Collaborator

@vinay033 vinay033 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good to me.
always use -s when you commit your changes.

Jay Mundrawala and others added 16 commits February 8, 2021 09:19
Looks like erlang 18 is no longer supported by parse_trans since
uwiger/parse_trans@91f0243

Signed-off-by: Jay Mundrawala <[email protected]>
…e is enabled. (#4683)

Currently chef-server will not come up if automate is disabled in the dev vm.

This happens because data-collector is set to true(enable) by default. This change makes it such that data-collector will be enabled only if external or internal automate are enabled.

Co-authored-by: Jay Mundrawala <[email protected]>
Signed-off-by: Prajakta Purohit <[email protected]>
…lve (#4684)

Also, the resolver config reads the resolvers from /etc/resolve and
queries every few minutes. I checked with wireshark to make sure it
doesn't happen for every request.
Create a full integration test suite for the notifications service in go. Everything is tested via external interface. This enables reimplementing the notifications-service while maintaining API stability.

No work is done to run this test suite in Ci yet. It will make sense to do so once we've created the reimplementation of the notifications-service.

This suite will probably need some adaption to work against the new implementation of the notifications-service. That will be done when there is a new implementation to adapt to.

* Appease shellcheck
* Add golang integration tests for notifications service
* Organize unit tests
* Add integration tests for notifications service
* More test cases for notifications integration tests
Signed-off-by: Ian Maddaus <[email protected]>
We are rewriting the notifications service in go to align better with our engineering capabilities.

This change creates a `notifications-service2` component in the source tree. It can be compiled and packaged manually, but is hidden from pipeline builds using the `dev_only` option in the habitat `plan.sh` (the `automate-ui-devproxy` uses the same mechanism).

The `notifications-service2` is missing most of the functionality that it will eventually have/need. Currently it only implements configuration file loading. When run as a service it prints its config to the logs in a loop. This is a first step towards implementing the infrastructural components of the new notifications service.

* Habitat boilerplate for notifications-service2
* Add config to notifications2
* Cleanup
…#4690)

* intergration test of infra-proxy-service

Signed-off-by: Vivek Singh <[email protected]>

* more changes

Signed-off-by: Vivek Singh <[email protected]>

* Sample integration test using http calls to api gateway

Signed-off-by: Kallol Roy <[email protected]>

* intergration test of infra-proxy-service

Signed-off-by: Vivek Singh <[email protected]>

* Required global setup

Signed-off-by: Vivek Singh <[email protected]>

* GetServers test running

Signed-off-by: Vivek Singh <[email protected]>

* spin up local chef server dev

Signed-off-by: Vivek Singh <[email protected]>

* Changes to create auth_token while sending GRPC requests

Signed-off-by: Kallol Roy <[email protected]>

* Added local deployed chef server and its setup

Signed-off-by: Vivek Singh <[email protected]>

* fixes end of line issues

Signed-off-by: Vivek Singh <[email protected]>

* remove automate gateway integration test cases

Signed-off-by: Vivek Singh <[email protected]>

* run server unit test cases only

Signed-off-by: Vivek Singh <[email protected]>

* add integration test to ci

Signed-off-by: Vivek Singh <[email protected]>

* try with chef-automate dev deployinate

Signed-off-by: Vivek Singh <[email protected]>

* set CONTAINER_HOSTNAME env var

Signed-off-by: Vivek Singh <[email protected]>

* Trying to fix integration failure

Signed-off-by: Kallol Roy <[email protected]>

Co-authored-by: Kallol Roy <[email protected]>
…lient API (#4592)

* Reset client key

Signed-off-by: Vivek Singh <[email protected]>

* Fixes client reset issue and ignore 404 while deleting the client

Signed-off-by: Vivek Singh <[email protected]>

* Remove clientname optional params & minor comments update

Signed-off-by: Vivek Singh <[email protected]>

* Updated client detail API with key data

Signed-off-by: Vivek Singh <[email protected]>

* indentation changes and comments update

Signed-off-by: Vivek Singh <[email protected]>

* fixes indentation to spaces

Signed-off-by: Vivek Singh <[email protected]>

* comments updated

Signed-off-by: Vivek Singh <[email protected]>

* Rebase changes and comments update

Signed-off-by: Vivek Singh <[email protected]>

* comments update

Signed-off-by: Vivek Singh <[email protected]>
This pull request was triggered automatically via Expeditor.

This change falls under the obvious fix policy so no Developer Certificate of Origin (DCO) sign-off is required.

Co-authored-by: Chef Expeditor <[email protected]>
* client list using search API

Signed-off-by: Vivek Singh <[email protected]>

* default rows count if not provided

Signed-off-by: Vivek Singh <[email protected]>

* Use search query interface

Signed-off-by: Vivek Singh <[email protected]>

* fixes tabs to spaces

Signed-off-by: Vivek Singh <[email protected]>

* tabs to spaces

Signed-off-by: Vivek Singh <[email protected]>

* Renamed start & rows with page and per_page search params

Signed-off-by: Vivek Singh <[email protected]>

* remove untracked file pushed

Signed-off-by: Vivek Singh <[email protected]>

* Added client list search test cases

Signed-off-by: Vivek Singh <[email protected]>

* proto comments update

Signed-off-by: Vivek Singh <[email protected]>

* minor updates

Signed-off-by: Vivek Singh <[email protected]>

* proto changes

Signed-off-by: Vivek Singh <[email protected]>
…ion (#4659)

* search environments using search API

Signed-off-by: Vivek Singh <[email protected]>

* default per page records

Signed-off-by: Vivek Singh <[email protected]>

* refactored the code and rename search params with perpage & page

Signed-off-by: Vivek Singh <[email protected]>

* proto comments updates

Signed-off-by: Vivek Singh <[email protected]>

* Added page to response object and environments test cases

Signed-off-by: Vivek Singh <[email protected]>

* proto changes

Signed-off-by: Vivek Singh <[email protected]>

* reuse common protobuff

Signed-off-by: Vivek Singh <[email protected]>
Signed-off-by: chaitali-mane <[email protected]>
@chaitali-mane chaitali-mane requested a review from a team as a code owner February 12, 2021 13:14
Signed-off-by: chaitali-mane <[email protected]>
Signed-off-by: chaitali-mane <[email protected]>
Copy link
Contributor

@rickmarry rickmarry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great.. thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants