Notifications Rewrite: Service Stub #4712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel DeLeo <[email protected]>
Signed-off-by: Daniel DeLeo <[email protected]>
|
Deploy preview for chef-automate processing. Building with commit 0a7b8be https://app.netlify.com/sites/chef-automate/deploys/6021c003e6194d0008539c53 |
danielsdeleo
commented
Feb 8, 2021
| @@ -0,0 +1,65 @@ | |||
| -- ONE DOT ZERO MIGRATIONS: | |||
There was a problem hiding this comment.
I'm going to handle migrating the database to a consistent state in a future PR. For now having this file here makes the schema migration handling logic in the plan.sh happy.
Signed-off-by: Daniel DeLeo <[email protected]>
danielsdeleo
force-pushed
the
dan/new-notifications-svc
branch
from
b8dddc6 to
0a7b8be
Compare
rickmarry
approved these changes
Feb 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔩 Description: What code changed, and why?
We are rewriting the notifications service in go to align better with our engineering capabilities.
This change creates a
notifications-service2component in the source tree. It can be compiled and packaged manually, but is hidden from pipeline builds using thedev_onlyoption in the habitatplan.sh(theautomate-ui-devproxyuses the same mechanism).The
notifications-service2is missing most of the functionality that it will eventually have/need. Currently it only implements configuration file loading. When run as a service it prints its config to the logs in a loop. This is a first step towards implementing the infrastructural components of the new notifications service.👟 How to Build and Test the Change
In a fresh habitat studio,
start_all_services. Then runbuild components/notifications-service2/ && sl. The service should build without error and then get picked up by the deployment service. In the log output you will see the running configuration for the service.The unit tests for the config package can be run by
cd /src/components/notifications-service2andgo test -v pkg/config/*go