Allow nginx to start even if external automate upstream fails to resolve #4684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for chef-automate processing. Building with commit b01bc57 https://app.netlify.com/sites/chef-automate/deploys/60215a2549eb400007e5a629 |
jaym
approved these changes
Feb 5, 2021
jaym
reviewed
Feb 8, 2021
| @@ -82,6 +82,8 @@ | |||
| return "{{cfg.external_automate.token}}"; | |||
| } | |||
|
|
|||
| resolver local=on ipv6=off; | |||
There was a problem hiding this comment.
i think we can get rid of ipv6=off
Also, the resolver config reads the resolvers from /etc/resolve and queries every few minutes. I checked with wireshark to make sure it doesn't happen for every request. Co-authored-by: Prajakta Purohit <[email protected]> Signed-off-by: Jay Mundrawala <[email protected]>
Signed-off-by: Jay Mundrawala <[email protected]>
jaym
force-pushed
the
praj+jdm/external-automate-resolver
branch
from
b89a999 to
b01bc57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, the resolver config reads the resolvers from /etc/resolve and
queries every few minutes. I checked with wireshark to make sure it
doesn't happen for every request.
resolves: chef/chef-server#2181
Co-authored-by: Prajakta Purohit [email protected]
Signed-off-by: Jay Mundrawala [email protected]
🔩 Description: What code changed, and why?
⛓️ Related Resources
👍 Definition of Done
👟 How to Build and Test the Change
✅ Checklist
📷 Screenshots, if applicable