-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix links #4671
Fix links #4671
Conversation
Deploy preview for chef-automate ready! Built with commit 118c8c1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be useful (especially if you want anyone other than docs-team to review) to show a "before" and "after" screenshot of how the links are getting rendered.
In particular, see the entries on: | ||
|
||
* [Chef Habitat Best Practices](https://www.habitat.sh/docs/best-practices/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one got dropped; was that intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That page doesn't exist anymore and now redirects to docs.chef.io/habitat/sup/ which is the same as the link on line 258.
Signed-off-by: IanMadd <[email protected]>
Signed-off-by: IanMadd <[email protected]>
Signed-off-by: IanMadd <[email protected]>
🔩 Description: What code changed, and why?
This replaces links to pages in the old Hab docs site with links to the current Hab docs pages
This also replaces Edit on GitHub links with a partial that generates the GitHub page link.
⛓️ Related Resources
chef/chef-web-docs#2775
👍 Definition of Done
👟 How to Build and Test the Change
✅ Checklist
📷 Screenshots, if applicable