Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix links #4671

Merged
merged 3 commits into from
Feb 9, 2021
Merged

Fix links #4671

merged 3 commits into from
Feb 9, 2021

Conversation

IanMadd
Copy link
Contributor

@IanMadd IanMadd commented Jan 30, 2021

🔩 Description: What code changed, and why?

This replaces links to pages in the old Hab docs site with links to the current Hab docs pages
This also replaces Edit on GitHub links with a partial that generates the GitHub page link.

⛓️ Related Resources

chef/chef-web-docs#2775

👍 Definition of Done

👟 How to Build and Test the Change

✅ Checklist

📷 Screenshots, if applicable

@IanMadd IanMadd added the documentation Anything related to the Automate docs. label Jan 30, 2021
@IanMadd IanMadd requested a review from a team as a code owner January 30, 2021 01:20
@netlify
Copy link

netlify bot commented Jan 30, 2021

Deploy preview for chef-automate ready!

Built with commit 118c8c1

https://deploy-preview-4671--chef-automate.netlify.app

Copy link

@kagarmoe kagarmoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tenor-203472165

Copy link
Contributor

@msorens msorens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be useful (especially if you want anyone other than docs-team to review) to show a "before" and "after" screenshot of how the links are getting rendered.

In particular, see the entries on:

* [Chef Habitat Best Practices](https://www.habitat.sh/docs/best-practices/)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one got dropped; was that intentional?

Copy link
Contributor Author

@IanMadd IanMadd Jan 31, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That page doesn't exist anymore and now redirects to docs.chef.io/habitat/sup/ which is the same as the link on line 258.

@IanMadd IanMadd merged commit 70f0022 into master Feb 9, 2021
@IanMadd IanMadd deleted the im/fix_links branch February 9, 2021 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acceptance: verified documentation Anything related to the Automate docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants