Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(fonts): avoid referencing split woff files #899

Merged
merged 9 commits into from
Jun 22, 2018
Merged

fix(fonts): avoid referencing split woff files #899

merged 9 commits into from
Jun 22, 2018

Conversation

asudoh
Copy link
Contributor

@asudoh asudoh commented Jun 18, 2018

Overview

Porting IBM/plex#160.
Fixes #665.
Refs carbon-design-system/carbon-components-react#925.

Added

  • Non-split version of Plex .woff files.

Changed

  • Refs to Plex .woff files from split (by character code range) version to non-split version.

Testing / Reviewing

Testing should make sure fonts in IE is not broken.

@alisonjoseph
Copy link
Member

Fonts aren't loading in IE11 for me.
screen shot 2018-06-18 at 2 32 23 pm

@asudoh
Copy link
Contributor Author

asudoh commented Jun 19, 2018

Hi @alisonjoseph thank you for looking - Here’s the background on the issue you saw - In the dev env, the font is loaded from something like https://unpkg.com/carbon-components@latest/src/globals/fonts/IBMPlexSans-Regular.woff - Given we are introducing new fonts in this PR, we need to release the change to see it. To see the change before releasing, we need to change $font-path temporarily.

alisonjoseph
alisonjoseph approved these changes Jun 19, 2018
View reviewed changes
Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks

@tw15egan tw15egan merged commit ac6ed4c into carbon-design-system:master Jun 22, 2018
@carbon-bot
Copy link
Contributor

🎉 This PR is included in version 9.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@asudoh asudoh deleted the avoid-plex-split-woff branch June 22, 2018 22:08
asudoh added a commit to asudoh/carbon-components that referenced this pull request Jun 22, 2018
@asudoh
fix(fonts): avoid referencing split woff files (carbon-design-system#899
e699a09 
)

Porting IBM/plex#160.
Fixes carbon-design-system#665.
Refs carbon-design-system/carbon-components-react#925.
@asudoh asudoh mentioned this pull request Jun 22, 2018
Merged
tw15egan pushed a commit that referenced this pull request Jul 2, 2018
@asudoh @tw15egan
fix(fonts): avoid referencing split woff files (#899) (#927)
45e6c0e 
Porting IBM/plex#160.
Fixes #665.
Refs carbon-design-system/carbon-components-react#925.
@asudoh asudoh mentioned this pull request Oct 11, 2018
Closed
joshblack pushed a commit to joshblack/carbon that referenced this pull request May 2, 2019
@tonydiaz @alisonjoseph
fix: console.errors coming from using Datepicker (carbon-design-syste…
984434e 
…m#899)
joshblack pushed a commit to joshblack/carbon that referenced this pull request May 2, 2019
@alisonjoseph @joshblack
feat(slider): Light variation (carbon-design-system#937)
d6a593a 
* chore: Update .babelrc, resolves  carbon-design-system#885 (carbon-design-system#886)

* chore: Update .babelrc, resolves  carbon-design-system#885

* chore: Update pacage.json, resolves  carbon-design-system#885

* chore(build): fix babel config for test (carbon-design-system#892)

* feat(DatePicker): Added minDate and maxDate props and pass them on to flatpickr (carbon-design-system#887)

* feat(DatePicker): Added minDate and maxDate props and pass them on to flatpickr

* Updated story description

* fix: Pagination component's range and page text for no items (carbon-design-system#872)

* fix: Pagination component's range and page text for no items, resolves carbon-design-system#553

* fix: Update UTs for PaginationV2

* feat(SearchFilterButton): add support for attaching event handlers (carbon-design-system#896)

* fix(DatePicker): treat Flatpickr's default export as a constructor (carbon-design-system#890)

Fixes carbon-design-system#491.

* fix: console.errors coming from using Datepicker (carbon-design-system#899)

* fix(package): update flatpickr to version 4.5.0 (carbon-design-system#897)

* fix(package): update flatpickr to version 4.5.0

Closes carbon-design-system#893

* chore(package): update lockfile

https://npm.im/greenkeeper-lockfile

* fix(table-toolbar-search): add i18n support (carbon-design-system#903)

* fix(OverflowMenu): fix <ClickOutside> not covering floating menu (carbon-design-system#906)

Fixes carbon-design-system#628.

* fix(icon-skeleton): Add missing export for IconSkeleton component (carbon-design-system#917)

* fix(Search): make search icon description translatable (carbon-design-system#927)

Fixes carbon-design-system#923.

* fix(Tooltip): prevent aria-owns attribute being set unless the target really exists (carbon-design-system#926)

Fixes carbon-design-system#913.

* feat(slider): Add light prop to slider
joshblack pushed a commit to joshblack/carbon that referenced this pull request May 2, 2019
@kiett @alisonjoseph
feat(OverflowMenu): added onClose & onOpen to props to notify caller …
1fab65e 
…Menu's open state (carbon-design-system#889)

* feat(OverflowMenu): added onClose to props to notify menu is closed

* feat(OverflowMenu): moved onClose handler to componentDidUpdate

* feat(OverflowMenu): moved onClose handler to render() where state.open is surely changed

* feat(OverflowMenu): moved onClose handler to componentDidUpdate

* feat(OverflowMenu): add onOpen to notify caller menu's open state

* feat(OverflowMenu): moved onClose & onOpen handler to componentDidUpdate

* feat(OverflowMenu): added onClose to props to notify menu is closed

* chore(build): fix babel config for test (carbon-design-system#892)

* feat(OverflowMenu): moved onClose handler to componentDidUpdate

* feat(OverflowMenu): moved onClose handler to render() where state.open is surely changed

* feat(OverflowMenu): moved onClose handler to componentDidUpdate

* feat(DatePicker): Added minDate and maxDate props and pass them on to flatpickr (carbon-design-system#887)

* feat(DatePicker): Added minDate and maxDate props and pass them on to flatpickr

* Updated story description

* fix: Pagination component's range and page text for no items (carbon-design-system#872)

* fix: Pagination component's range and page text for no items, resolves carbon-design-system#553

* fix: Update UTs for PaginationV2

* feat(SearchFilterButton): add support for attaching event handlers (carbon-design-system#896)

* fix(DatePicker): treat Flatpickr's default export as a constructor (carbon-design-system#890)

Fixes carbon-design-system#491.

* fix: console.errors coming from using Datepicker (carbon-design-system#899)

* fix(package): update flatpickr to version 4.5.0 (carbon-design-system#897)

* fix(package): update flatpickr to version 4.5.0

Closes carbon-design-system#893

* chore(package): update lockfile

https://npm.im/greenkeeper-lockfile

* fix(table-toolbar-search): add i18n support (carbon-design-system#903)

* fix(OverflowMenu): fix <ClickOutside> not covering floating menu (carbon-design-system#906)

Fixes carbon-design-system#628.

* feat(OverflowMenu): add onOpen to notify caller menu's open state

* feat(OverflowMenu): moved onClose & onOpen handler to componentDidUpdate

* feat(OverflowMenu): moved onOpen call hook to_handlePlace

* feat(OverflowMenu): refine from Josh and Akira's reviews

* feat(OverflowMenu): refine from Josh and Akira's reviews

* feat(OverflowMenu): refine from Josh and Akira's reviews
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alisonjoseph alisonjoseph alisonjoseph approved these changes

@tw15egan tw15egan tw15egan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@asudoh @alisonjoseph @carbon-bot @tw15egan @marijohannessen