Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout Scale Variables not defined #885

Closed
smandava opened this issue Jun 8, 2018 · 2 comments
Closed

Layout Scale Variables not defined #885

smandava opened this issue Jun 8, 2018 · 2 comments
Assignees

Comments

@smandava
Copy link

smandava commented Jun 8, 2018

Detailed description

I'm not able to use Layout scale variables such as $layout-2xs, $layout-xs etc as documented in the spacing section of style guide. I get Undefined variable: "$layout-xs" SCCS error.

What version of the Carbon Design System are you using?

9.02

Steps to reproduce the issue

  • git clone https://github.com/carbon-design-system/carbon-boilerplate.git
  • cd carbon-boilerplate
  • npm install or yarn
  • Specify padding as a $layout-xl in app\scss\main.scss as shown below
.container {
-  padding: 2rem 5% 0;
+  padding: $layout-xl 5% 0;
 }
  • npm run dev
  • I'm getting the following error:
Error: app\scss\main.scss
Error: Undefined variable: "$layout-xl".
        on line 8 of app/scss/main.scss
>>   padding: $layout-xl 5% 0;
   -----------^
@smandava smandava changed the title Layout Scale Variables not defines Layout Scale Variables not defined Jun 8, 2018
@alisonjoseph alisonjoseph self-assigned this Jun 18, 2018
@alisonjoseph
Copy link
Member

Hi @smandava thanks for catching this, I'm working on getting them added now.

@carbon-bot
Copy link
Contributor

🎉 This issue has been resolved in version 9.0.13 🎉

The release is available on:

Your semantic-release bot 📦🚀

joshblack pushed a commit to joshblack/carbon that referenced this issue May 2, 2019
joshblack pushed a commit to joshblack/carbon that referenced this issue May 2, 2019
* chore: Update .babelrc, resolves  carbon-design-system#885 (carbon-design-system#886)

* chore: Update .babelrc, resolves  carbon-design-system#885

* chore: Update pacage.json, resolves  carbon-design-system#885

* chore(build): fix babel config for test (carbon-design-system#892)

* feat(DatePicker): Added minDate and maxDate props and pass them on to flatpickr (carbon-design-system#887)

* feat(DatePicker): Added minDate and maxDate props and pass them on to flatpickr

* Updated story description

* fix: Pagination component's range and page text for no items (carbon-design-system#872)

* fix: Pagination component's range and page text for no items, resolves carbon-design-system#553

* fix: Update UTs for PaginationV2

* feat(SearchFilterButton): add support for attaching event handlers (carbon-design-system#896)

* fix(DatePicker): treat Flatpickr's default export as a constructor (carbon-design-system#890)

Fixes carbon-design-system#491.

* fix: console.errors coming from using Datepicker (carbon-design-system#899)

* fix(package): update flatpickr to version 4.5.0 (carbon-design-system#897)

* fix(package): update flatpickr to version 4.5.0

Closes carbon-design-system#893

* chore(package): update lockfile

https://npm.im/greenkeeper-lockfile

* fix(table-toolbar-search): add i18n support (carbon-design-system#903)

* fix(OverflowMenu): fix <ClickOutside> not covering floating menu (carbon-design-system#906)

Fixes carbon-design-system#628.

* fix(icon-skeleton): Add missing export for IconSkeleton component (carbon-design-system#917)

* fix(Search): make search icon description translatable (carbon-design-system#927)

Fixes carbon-design-system#923.

* fix(Tooltip): prevent aria-owns attribute being set unless the target really exists (carbon-design-system#926)

Fixes carbon-design-system#913.

* feat(slider): Add light prop to slider
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants