fix(css): reference complete woff file, do not reference split woff files #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshblack
approved these changes
Apr 15, 2018
scripts/tools/index.js
Outdated
| @@ -16,7 +16,7 @@ exports.formatFilename = formatFilename; | |||
| * `createFontFace` is used to generate the actual `@font-face` declarations | |||
| * that get written to the appropriate files. | |||
| */ | |||
| const createFontFace = (filename, family, weight, unicode) => { | |||
| const createFontFace = (filename, family, weight, unicode = {type: ''}) => { | |||
There was a problem hiding this comment.
Do we need the default type: '' here, or just the object? e.g. unicode = {}. Just curious!
asudoh
added a commit
to asudoh/carbon-components
that referenced
this pull request
Jun 15, 2018
asudoh
added a commit
to asudoh/carbon-components
that referenced
this pull request
Jun 18, 2018
Porting IBM/plex#160. Fixes carbon-design-system#665. Refs carbon-design-system/carbon-components-react#925.
tw15egan
pushed a commit
to carbon-design-system/carbon
that referenced
this pull request
Jun 22, 2018
Porting IBM/plex#160. Fixes #665. Refs carbon-design-system/carbon-components-react#925.
asudoh
added a commit
to asudoh/carbon-components
that referenced
this pull request
Jun 22, 2018
) Porting IBM/plex#160. Fixes carbon-design-system#665. Refs carbon-design-system/carbon-components-react#925.
tw15egan
pushed a commit
to carbon-design-system/carbon
that referenced
this pull request
Jul 2, 2018
Porting IBM/plex#160. Fixes #665. Refs carbon-design-system/carbon-components-react#925.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would close #110.
We discovered that IE11 needs
.wofffile references without unicode ranges. This places a.woffreference for the whole typeface weight above the unicode range references using.woff2. I kept the split.wofffiles so this would not be a breaking change.It was tested and shown to use the
woff2splits on Chrome, but thewoffcomplete on IE11.