Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IE 11 Bug: ellipsis not showing when text-overflow: ellipsis with ibm-plex-sans font #665

Closed
flyHe opened this issue Mar 20, 2018 · 6 comments
Closed

IE 11 Bug: ellipsis not showing when text-overflow: ellipsis with ibm-plex-sans font #665

flyHe opened this issue Mar 20, 2018 · 6 comments

Comments

@flyHe
Copy link

flyHe commented Mar 20, 2018 •
edited
Loading

Detailed description

Describe in detail the issue you're having. Is this a feature request (new component, new icon), a bug, or a general issue?

a long name should be hidden with ellipsis, but ellipsis was not showing in IE11, and I found the ibm-plex-sans font make the ellipsis in mess, if I remove the ibm-plex-sans, it worked as normal

Is this issue related to a specific component?

no

What did you expect to happen? What happened instead? What would you like to see changed?

ellipsis should be shown in IE11 with long name when text-overflow: ellipsis

What browser are you working in?

IE 11

What version of the Carbon Design System are you using?

"carbon-components": "^8.10.0",

What offering/product do you work on? Any pressing ship or release dates we should be aware of?

Steps to reproduce the issue

  1. Step one
  2. Step two
  3. Step three
  4. etc.

Additional information

  • Screenshots or code
  • Notes

ibm-plex-sans
screen shot 2018-03-20 at 4 31 44 pm
screen shot 2018-03-20 at 4 32 12 pm

Without ibm-plex-sans
screen shot 2018-03-20 at 4 36 47 pm

Add labels

Please choose the appropriate label(s) from our existing label list to ensure that your issue is properly categorized. This will help us to better understand and address your issue.
@tw15egan
Copy link
Contributor

Is this a problem with the font itself? If so, it may be better to open an issue here: https://github.com/IBM/plex

@flyHe
Copy link
Author

flyHe commented Mar 21, 2018 •
edited
Loading

@tw15egan I am not sure if this is an issue with the font itself, the font is imported by carbon using $css--plex: true;, and I also have opened a same issue in IBM/plex#150

@flyHe
Copy link
Author

flyHe commented Mar 21, 2018

a related issue IBM/plex#110,

@alisonjoseph
Copy link
Member

alisonjoseph commented May 18, 2018 •
edited
Loading

closing, fix included in this PR IBM/plex#160

asudoh added a commit to asudoh/carbon-components that referenced this issue Jun 18, 2018
@asudoh
fix(fonts): avoid referencing split woff files
995bb8a 
Porting IBM/plex#160.
Fixes carbon-design-system#665.
Refs carbon-design-system/carbon-components-react#925.
@asudoh asudoh mentioned this issue Jun 18, 2018
Merged
tw15egan pushed a commit that referenced this issue Jun 22, 2018
@asudoh @tw15egan
fix(fonts): avoid referencing split woff files (#899)
ac6ed4c 
Porting IBM/plex#160.
Fixes #665.
Refs carbon-design-system/carbon-components-react#925.
@carbon-bot
Copy link
Contributor

🎉 This issue has been resolved in version 9.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

asudoh added a commit to asudoh/carbon-components that referenced this issue Jun 22, 2018
@asudoh
fix(fonts): avoid referencing split woff files (carbon-design-system#899
e699a09 
)

Porting IBM/plex#160.
Fixes carbon-design-system#665.
Refs carbon-design-system/carbon-components-react#925.
@asudoh asudoh mentioned this issue Jun 22, 2018
Merged
tw15egan pushed a commit that referenced this issue Jul 2, 2018
@asudoh @tw15egan
fix(fonts): avoid referencing split woff files (#899) (#927)
45e6c0e 
Porting IBM/plex#160.
Fixes #665.
Refs carbon-design-system/carbon-components-react#925.
@dsuwirya dsuwirya mentioned this issue Sep 11, 2018
Closed
@asudoh asudoh mentioned this issue Sep 12, 2018
Closed
joshblack added a commit to joshblack/carbon that referenced this issue May 2, 2019
@joshblack
fix(DataTable): handle no rows in DataTable case for selection (carbo…
12d9915 
…n-design-system#665)

* fix(DataTable): handle no rows in DataTable case for selection

* chore(test): update snapshots
@damorossi
Copy link

this is not a font matter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@alisonjoseph @damorossi @flyHe @tw15egan @carbon-bot