daemon/mount: Avoid potential race if sshfs_mount exits quickly #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #514 +/- ##
=======================================
Coverage 66.45% 66.45%
=======================================
Files 146 146
Lines 5676 5676
=======================================
Hits 3772 3772
Misses 1904 1904
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #514 +/- ##
=======================================
Coverage 66.45% 66.45%
=======================================
Files 146 146
Lines 5676 5676
=======================================
Hits 3772 3772
Misses 1904 1904
Continue to review full report at Codecov.
|
This will avoid a state where the sftp_server/sshfs pair is not running, but the daemon still holds the info in memory. Fixes #511
townsend2010
force-pushed
the
fix-mount-failure-race
branch
from
7b6556e to
d124766
Compare
ricab
reviewed
Dec 7, 2018
ricab
approved these changes
Dec 7, 2018
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Dec 7, 2018
514: daemon/mount: Avoid potential race if sshfs_mount exits quickly r=ricab a=townsend2010 This will avoid a state where the sftp_server/sshfs pair is not running, but the daemon still holds the info in memory. Fixes #511 Co-authored-by: Chris Townsend <[email protected]>
Build succeeded |
Merged
bors bot
added a commit
that referenced
this pull request
Dec 20, 2018
551: Release 2018.12.1 r=townsend2010 a=Saviq ### Highlights - On Linux, suspending/resuming the instance to/from disk is now supported. (#374) - Better handling of delayed shutdown including posting `wall` messages to logged in users and allowing log ins to the instance unless 1 minute or less remains until shutdown. (#461, #50) - On Linux, all CPU flags should be passed into the running instance on newly created instances. (#516) - Fixed some races around mount handling. (#514, #520) ### Bugs fixed: - make the recover command idempotent (#528) - explicitly stop mounts when deleting an instance to avoid a race (#520) - be smarter about what group owns the multipass socket (#513, #523) - pass through all CPU flags when launching QEMU or libvirt instances (#516) - use `info` log level for metrics issues (#515) - fix potential race when starting a mount (#514) - use `wall` shutdown messages for users logged into VM when delayed shutdown is initiated (#501) - fix crash if exception during daemon start up (#487) - refactor CLI code (#468) - add default uid/gid mapping (#331) - fix file metadata passthrough - display uid/gid maps in info command (#439) - add support for the suspend command (#374) - shell to machine in delayed stop state (#461) - improve uid/gid validation (#479) - avoid leaking the libvirt bridge (#327, #413) - add a restart command (#217) - upgrade 3rd-party versions (#471) Co-authored-by: bors[bot] <bors[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will avoid a state where the sftp_server/sshfs pair is not running, but the daemon still holds the info in memory.
Fixes #511