Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing multipass leaves mpvirtbr0 bridge behind #327

Closed
morphis opened this issue Aug 8, 2018 · 1 comment · Fixed by #427
Closed

Removing multipass leaves mpvirtbr0 bridge behind #327

morphis opened this issue Aug 8, 2018 · 1 comment · Fixed by #427
Labels
Milestone

Comments

@morphis
Copy link

morphis commented Aug 8, 2018

I installed the multipass snap (revision 334 from beta channel) and configured it to use the libvirt driver. I created a few containers and then removed the multipass snap from the system. After the snap was removed there was still a mpvirtbr0 network device present. A new installation of the multipass snap caused now a mpvirtbr1 device to be created which will cause multipass to not find the right network bridge when the system is rebooted. libvirt will fail to start then with:

Aug 08 10:06:44 saturn libvirtd[3188]: Cannot get interface MTU on 'mpvirtbr1': No such device

and multipassd with

Aug 06 09:07:54 saturn multipass.multipassd[5868]: libvirt: XML-RPC error : Failed to connect socket to '/var/snap/multipass/common/run/libvirt/libvirt-sock': Connection refused

Only way to get out of this is to manually modify the configuration of all present containers to use mpvirtbr0 instead of mpvirtbr1.

@Saviq Saviq added the bug label Aug 8, 2018
@Saviq
Copy link
Collaborator

Saviq commented Aug 8, 2018

So we're trying to clean up the bridge on exit (bug part no. 1) and create a new bridge when one exists already on startup (bug part no.2). I wonder if we should just take over the existing one instead? After all there's no good reason for a user to have a mpvirtbr0 on their system...

townsend2010 pushed a commit that referenced this issue Oct 2, 2018
Revert back to using a non-persistent libvirt network and instead, save the subnet
like is done for the Qemu backend.

Fixes #327, fixes #413
bors bot added a commit that referenced this issue Nov 13, 2018
427: libvirt: Destroy bridge in the LibVirtVirtualMachineFactory dtor r=Saviq a=townsend2010

Revert back to using a non-persistent libvirt network and instead, save the subnet
like is done for the Qemu backend.

Fixes #327, fixes #413

Co-authored-by: Chris Townsend <[email protected]>
bors bot added a commit that referenced this issue Nov 13, 2018
427: libvirt: Destroy bridge in the LibVirtVirtualMachineFactory dtor r=Saviq a=townsend2010

Revert back to using a non-persistent libvirt network and instead, save the subnet
like is done for the Qemu backend.

Fixes #327, fixes #413

Co-authored-by: Chris Townsend <[email protected]>
townsend2010 pushed a commit that referenced this issue Nov 13, 2018
Revert back to using a non-persistent libvirt network and instead, save the subnet
like is done for the Qemu backend.

Fixes #327, fixes #413
bors bot added a commit that referenced this issue Nov 13, 2018
427: libvirt: Destroy bridge in the LibVirtVirtualMachineFactory dtor r=Saviq a=townsend2010

Revert back to using a non-persistent libvirt network and instead, save the subnet
like is done for the Qemu backend.

Fixes #327, fixes #413

Co-authored-by: Chris Townsend <[email protected]>
@bors bors bot closed this as completed in #427 Nov 13, 2018
@Saviq Saviq added this to the 2018.12.1 milestone Dec 14, 2018
bors bot added a commit that referenced this issue Dec 20, 2018
551: Release 2018.12.1 r=townsend2010 a=Saviq

### Highlights

- On Linux, suspending/resuming the instance to/from disk is now supported. (#374)
- Better handling of delayed shutdown including posting `wall` messages to logged in users and allowing log ins to the instance unless 1 minute or less remains until shutdown. (#461, #50) 
- On Linux, all CPU flags should be passed into the running instance on newly created instances. (#516)
- Fixed some races around mount handling. (#514, #520)

### Bugs fixed:

- make the recover command idempotent (#528)
- explicitly stop mounts when deleting an instance to avoid a race (#520)
- be smarter about what group owns the multipass socket (#513, #523) 
- pass through all CPU flags when launching QEMU or libvirt instances (#516)
- use `info` log level for metrics issues (#515)
- fix potential race when starting a mount (#514)
- use `wall` shutdown messages for users logged into VM when delayed shutdown is initiated (#501)
- fix crash if exception during daemon start up (#487)
- refactor CLI code (#468)
- add default uid/gid mapping (#331)
- fix file metadata passthrough
- display uid/gid maps in info command (#439)
- add support for the suspend command (#374)
- shell to machine in delayed stop state (#461)
- improve uid/gid validation (#479)
- avoid leaking the libvirt bridge (#327, #413)
- add a restart command (#217)
- upgrade 3rd-party versions (#471)

Co-authored-by: bors[bot] <bors[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants