Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delayed shutdown prevents shelling in #461

Closed
Saviq opened this issue Oct 25, 2018 · 1 comment
Closed

Delayed shutdown prevents shelling in #461

Saviq opened this issue Oct 25, 2018 · 1 comment
Labels
bug good first issue help wanted
Milestone
2018.12.1

Comments

@Saviq
Copy link
Collaborator

Saviq commented Oct 25, 2018

Steps:

$ multipass stop <instance> --time +10
$ multipass shell <instance>
shell failed: instance "snapcraft-multipass" is not running

It should instead cancel the shutdown.
@pekof
Copy link
Contributor

pekof commented Oct 26, 2018 •
edited
Loading

I wouldn't expect shutdown to be canceled without someone issuing cancel command.
But connect/shell should work until shutdown is initiated

I will look into this.

@pekof pekof mentioned this issue Oct 26, 2018
Merged
bors bot added a commit that referenced this issue Oct 30, 2018
@bors @pekof
Merge #465
3810134 
465: shell to machine in delayed-shutdown state r=Saviq a=pekof

Fix bug #461 
ssh_info returns connection data if machine is still running

Co-authored-by: pekof <[email protected]>
bors bot added a commit that referenced this issue Oct 30, 2018
@bors @pekof
Merge #465
90a7057 
465: shell to machine in delayed-shutdown state r=saviq a=pekof

Fix bug #461 
ssh_info returns connection data if machine is still running

Co-authored-by: pekof <[email protected]>
@Saviq Saviq added this to the 2018.12.1 milestone Dec 14, 2018
@Saviq Saviq mentioned this issue Dec 20, 2018
Merged
bors bot added a commit that referenced this issue Dec 20, 2018
@bors
Merge #551
f15e279 
551: Release 2018.12.1 r=townsend2010 a=Saviq

### Highlights

- On Linux, suspending/resuming the instance to/from disk is now supported. (#374)
- Better handling of delayed shutdown including posting `wall` messages to logged in users and allowing log ins to the instance unless 1 minute or less remains until shutdown. (#461, #50) 
- On Linux, all CPU flags should be passed into the running instance on newly created instances. (#516)
- Fixed some races around mount handling. (#514, #520)

### Bugs fixed:

- make the recover command idempotent (#528)
- explicitly stop mounts when deleting an instance to avoid a race (#520)
- be smarter about what group owns the multipass socket (#513, #523) 
- pass through all CPU flags when launching QEMU or libvirt instances (#516)
- use `info` log level for metrics issues (#515)
- fix potential race when starting a mount (#514)
- use `wall` shutdown messages for users logged into VM when delayed shutdown is initiated (#501)
- fix crash if exception during daemon start up (#487)
- refactor CLI code (#468)
- add default uid/gid mapping (#331)
- fix file metadata passthrough
- display uid/gid maps in info command (#439)
- add support for the suspend command (#374)
- shell to machine in delayed stop state (#461)
- improve uid/gid validation (#479)
- avoid leaking the libvirt bridge (#327, #413)
- add a restart command (#217)
- upgrade 3rd-party versions (#471)

Co-authored-by: bors[bot] <bors[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first issue help wanted
Projects
None yet
Milestone
2018.12.1
Development

No branches or pull requests
3 participants
@Saviq @townsend2010 @pekof