Fix daemon missing group #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saviq
requested changes
Dec 11, 2018
Codecov Report
@@ Coverage Diff @@
## master #513 +/- ##
==========================================
- Coverage 66.45% 66.32% -0.13%
==========================================
Files 146 146
Lines 5676 5687 +11
==========================================
Hits 3772 3772
- Misses 1904 1915 +11
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #513 +/- ##
==========================================
- Coverage 66.45% 66.29% -0.17%
==========================================
Files 146 146
Lines 5679 5693 +14
==========================================
Hits 3774 3774
- Misses 1905 1919 +14
Continue to review full report at Codecov.
|
|
This should give me a better error now, no? |
|
Not if multipassd is not running, which seems to be your case based on the |
Saviq
requested changes
Dec 11, 2018
Saviq
reviewed
Dec 11, 2018
Fall back to 'root' if those groups don't exist on the host instead of throwing an exception. Fixes #456
This will detect if the user has proper permission to access the Unix domain socket file. Fixes #460
Co-Authored-By: townsend2010 <[email protected]>
Co-Authored-By: townsend2010 <[email protected]>
Co-Authored-By: townsend2010 <[email protected]>
townsend2010
force-pushed
the
fix-daemon-missing-group
branch
from
2624d7f to
1eddc05
Compare
Saviq
requested changes
Dec 11, 2018
Co-Authored-By: townsend2010 <[email protected]>
Saviq
reviewed
Dec 11, 2018
include/multipass/cli/command.h
Outdated
| return on_failure(status); | ||
| else | ||
| { | ||
| fmt::print("{}\n", context.peer()); |
Saviq
approved these changes
Dec 11, 2018
|
bors delegate+ bors? |
townsend2010
force-pushed
the
fix-daemon-missing-group
branch
from
ac82958 to
8c00a1d
Compare
|
bors r=Saviq |
bors bot
added a commit
that referenced
this pull request
Dec 11, 2018
513: Fix daemon missing group r=Saviq a=townsend2010 I combined a few fixes in this as separate commits since they all went hand in hand and solve a couple of issues together. Fixes #456, fixes #460 Co-authored-by: Chris Townsend <[email protected]> Co-authored-by: Michał Sawicz <[email protected]>
Build failed |
|
Ok, try again... bors r=Saviq |
bors bot
added a commit
that referenced
this pull request
Dec 11, 2018
513: Fix daemon missing group r=Saviq a=townsend2010 I combined a few fixes in this as separate commits since they all went hand in hand and solve a couple of issues together. Fixes #456, fixes #460 Co-authored-by: Chris Townsend <[email protected]> Co-authored-by: Michał Sawicz <[email protected]>
Build failed |
|
One more time... bors r=Saviq |
bors bot
added a commit
that referenced
this pull request
Dec 11, 2018
513: Fix daemon missing group r=Saviq a=townsend2010 I combined a few fixes in this as separate commits since they all went hand in hand and solve a couple of issues together. Fixes #456, fixes #460 Co-authored-by: Chris Townsend <[email protected]> Co-authored-by: Michał Sawicz <[email protected]>
Build failed |
Merged
bors bot
added a commit
that referenced
this pull request
Dec 20, 2018
551: Release 2018.12.1 r=townsend2010 a=Saviq ### Highlights - On Linux, suspending/resuming the instance to/from disk is now supported. (#374) - Better handling of delayed shutdown including posting `wall` messages to logged in users and allowing log ins to the instance unless 1 minute or less remains until shutdown. (#461, #50) - On Linux, all CPU flags should be passed into the running instance on newly created instances. (#516) - Fixed some races around mount handling. (#514, #520) ### Bugs fixed: - make the recover command idempotent (#528) - explicitly stop mounts when deleting an instance to avoid a race (#520) - be smarter about what group owns the multipass socket (#513, #523) - pass through all CPU flags when launching QEMU or libvirt instances (#516) - use `info` log level for metrics issues (#515) - fix potential race when starting a mount (#514) - use `wall` shutdown messages for users logged into VM when delayed shutdown is initiated (#501) - fix crash if exception during daemon start up (#487) - refactor CLI code (#468) - add default uid/gid mapping (#331) - fix file metadata passthrough - display uid/gid maps in info command (#439) - add support for the suspend command (#374) - shell to machine in delayed stop state (#461) - improve uid/gid validation (#479) - avoid leaking the libvirt bridge (#327, #413) - add a restart command (#217) - upgrade 3rd-party versions (#471) Co-authored-by: bors[bot] <bors[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I combined a few fixes in this as separate commits since they all went hand in hand and solve a couple of issues together.
Fixes #456, fixes #460