Brave syncer #2010
Merged
Brave syncer #2010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkdh
force-pushed
the
brave-syncer
branch
5 times, most recently
from
00e1d5a to
300aaa2
Compare
darkdh
force-pushed
the
brave-syncer
branch
6 times, most recently
from
0b34a8b to
47e2612
Compare
darkdh
force-pushed
the
brave-syncer
branch
3 times, most recently
from
29b7ad2 to
3dc3465
Compare
darkdh
force-pushed
the
brave-syncer
branch
5 times, most recently
from
48d583b to
8c4cb39
Compare
AlexeyBarabash
force-pushed
the
brave-syncer
branch
from
c62cd58 to
9a9b5f7
Compare
darkdh
force-pushed
the
brave-syncer
branch
5 times, most recently
from
f80b0d2 to
a8a5f2b
Compare
1. legacy order will still be sent for compatibility 2. legacy order will be used when there is no position_in_parent (legacy sync) during applying remote changes
1. Patch standardization 2. Apply clang-format
1. Remvoe weak_ptr for syncer and make sure get_record_cb_ won't get called when sync_thread is not running 2. Remove unnecessary forward declaration
1. Generate fake NIGORI entity when apply update 2. Set dummy encryption key for every update_response
sync protocol like "version" and "UniquePosition", ...etc
bridiver
approved these changes
Aug 20, 2019
|
CI shows all green but reported aborted |
|
it was actually get terminated (https://staging.ci.brave.com/job/brave-browser-build-pr/job/brave-syncer/101/execution/node/425/log/) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brave browser branch: brave-syncer
chromium: 76.0.3809.100
fix brave/brave-browser#2754
Overview:
This PR intercepts syncer's nudge/poll jobs to add brave sync records from brave/sync client.
Applying remote changes and committing local changes leverages chromium BookmarkChangeProcessor with minimal changes
Future work:
kSyncUSSBookmarks (https://www.chromium.org/developers/design-documents/sync/unified-sync-and-storage-overview)
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests) onnpm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist: