-
Notifications
You must be signed in to change notification settings - Fork 900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Brave syncer (uplift to 0.69.x) #3230
Conversation
05086d8
to
d0a91db
Compare
Register prefs in right places
Fix WidevineBundleManager unit tests crash
Brave syncer
Update sync nodes index only when we are about to moving the nodes from end to proper position
d0a91db
to
a2c2264
Compare
@darkdh mind taking a quick look at https://staging.ci.brave.com/job/brave-browser-build-pr/job/brave-syncer-0.69.x/5/execution/node/502/log/? Seems like it failed due to too many broken tests. Example:
However, it looks like #3232 passed without any issues other than the |
that means the CI instance has gotten into a bad state which we usually need to kill zombie processes or even restart the machine on local machine, otherwise all the browser test will keep timing out. Wiped out the workspace and restarted a new build. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uplift into 0.69.x
approved after deliberating with @brave/uplift-approvers. Looks like both CI/Jenkins
and CI/Travis
passed without any issues. @btlechowski has also gone through brave/brave-browser#2754 (comment).
Please make sure that all the correct labels are added and the appropriate issue is moved into the correct milestone.
Brave syncer (uplift to 0.69.x)
Uplift of #2010 which is required by upcoming C77 bump
#3241 is the bookmark out of order fix
#3031 and #3148 are required by #2010 so also uplift them