Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave syncer (uplift to 0.69.x) #3230

Merged
merged 4 commits into from
Aug 28, 2019
Merged

Brave syncer (uplift to 0.69.x) #3230

merged 4 commits into from
Aug 28, 2019

Conversation

darkdh
Copy link
Member

@darkdh darkdh commented Aug 20, 2019

Uplift of #2010 which is required by upcoming C77 bump
#3241 is the bookmark out of order fix

#3031 and #3148 are required by #2010 so also uplift them

@darkdh darkdh added this to the 0.69.x - Beta milestone Aug 20, 2019
@darkdh darkdh requested review from bbondy and a team August 20, 2019 22:45
@darkdh darkdh requested a review from bridiver as a code owner August 20, 2019 22:45
@darkdh darkdh self-assigned this Aug 20, 2019
@darkdh darkdh force-pushed the brave-syncer-0.69.x branch from 05086d8 to d0a91db Compare August 21, 2019 03:56
darkdh and others added 4 commits August 23, 2019 09:52
Register prefs in right places
Update sync nodes index only when we are about to moving the nodes from end to proper position
@darkdh darkdh force-pushed the brave-syncer-0.69.x branch from d0a91db to a2c2264 Compare August 23, 2019 17:03
@kjozwiak
Copy link
Member

@darkdh mind taking a quick look at https://staging.ci.brave.com/job/brave-browser-build-pr/job/brave-syncer-0.69.x/5/execution/node/502/log/? Seems like it failed due to too many broken tests. Example:

14:05:42  [ RUN      ] BraveSaveCardBubbleControllerImplTest.NoSignInPromoBraveSyncEnabled
14:05:42  [19/223] BraveSaveCardBubbleControllerImplTest.NoSignInPromoBraveSyncEnabled (TIMED OUT)
14:05:42  [ RUN      ] BraveContentSettingsRegistryBrowserTest.WithBraveShieldsContentSetting
14:05:42  [20/223] BraveContentSettingsRegistryBrowserTest.WithBraveShieldsContentSetting (TIMED OUT)
14:05:42  [ RUN      ] SecurityIndicatorTest.CheckIndicatorText
14:05:42  [21/223] SecurityIndicatorTest.CheckIndicatorText (TIMED OUT)
14:05:42  [ RUN      ] BraveContentSettingsRegistryBrowserTest.WithWildcardContentSetting
14:05:42  [22/223] BraveContentSettingsRegistryBrowserTest.WithWildcardContentSetting (TIMED OUT)
14:05:42  Too many badly broken tests (22), exiting now.

However, it looks like #3232 passed without any issues other than the S3 upload failure which isn't related to this particular PR.

@darkdh
Copy link
Member Author

darkdh commented Aug 27, 2019

that means the CI instance has gotten into a bad state which we usually need to kill zombie processes or even restart the machine on local machine, otherwise all the browser test will keep timing out.

Wiped out the workspace and restarted a new build.

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 0.69.x approved after deliberating with @brave/uplift-approvers. Looks like both CI/Jenkins and CI/Travis passed without any issues. @btlechowski has also gone through brave/brave-browser#2754 (comment).

Please make sure that all the correct labels are added and the appropriate issue is moved into the correct milestone.

@bbondy bbondy merged commit 0e9d471 into 0.69.x Aug 28, 2019
@bsclifton bsclifton deleted the brave-syncer-0.69.x branch August 28, 2019 05:28
bsclifton pushed a commit that referenced this pull request Sep 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants