-
Notifications
You must be signed in to change notification settings - Fork 900
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
3 changed files
with
24 additions
and
31 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
diff --git a/components/sync/base/model_type.h b/components/sync/base/model_type.h | ||
index ca6acf4cdbded08bbd1a69c27827ecf0374a0d11..56f2ae314dfff6d8df3df67ec1edd9b92d1d9d93 100644 | ||
--- a/components/sync/base/model_type.h | ||
+++ b/components/sync/base/model_type.h | ||
@@ -271,6 +271,7 @@ constexpr ModelTypeSet ProxyTypes() { | ||
// - They support custom update application and conflict resolution logic. | ||
// - All change processing occurs on the sync thread (GROUP_PASSIVE). | ||
constexpr ModelTypeSet ControlTypes() { | ||
+ return ModelTypeSet(UNSPECIFIED); | ||
return ModelTypeSet::FromRange(FIRST_CONTROL_MODEL_TYPE, | ||
LAST_CONTROL_MODEL_TYPE); | ||
} |
21 changes: 11 additions & 10 deletions
21
patches/components-sync-driver-data_type_manager_impl.cc.patch
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,14 +1,15 @@ | ||
diff --git a/components/sync/driver/data_type_manager_impl.cc b/components/sync/driver/data_type_manager_impl.cc | ||
index 9dc9226269704e8a2412634b231a6d54c8bc93f6..b40ac1bbef7ccb7b29022176d11e725a86ac7835 100644 | ||
index 9dc9226269704e8a2412634b231a6d54c8bc93f6..c746e46fdec8c992fcafb87f3e89927979165019 100644 | ||
--- a/components/sync/driver/data_type_manager_impl.cc | ||
+++ b/components/sync/driver/data_type_manager_impl.cc | ||
@@ -596,7 +596,8 @@ ModelTypeSet DataTypeManagerImpl::PrepareConfigureParams( | ||
DCHECK(Intersection(downloaded_types_, types_to_journal).Empty()); | ||
DCHECK(Intersection(downloaded_types_, crypto_types).Empty()); | ||
// |downloaded_types_| was already updated to include all enabled types. | ||
- DCHECK(downloaded_types_.HasAll(types_to_download)); | ||
+ // TODO(darkdh): fix Control Type download | ||
+ // DCHECK(downloaded_types_.HasAll(types_to_download)); | ||
@@ -546,8 +546,8 @@ ModelTypeSet DataTypeManagerImpl::PrepareConfigureParams( | ||
types_to_download.PutAll(clean_types); | ||
types_to_download.RemoveAll(ProxyTypes()); | ||
types_to_download.RemoveAll(CommitOnlyTypes()); | ||
- if (!types_to_download.Empty()) | ||
- types_to_download.Put(NIGORI); | ||
+ // if (!types_to_download.Empty()) | ||
+ // types_to_download.Put(NIGORI); | ||
|
||
DVLOG(1) << "Types " << ModelTypeSetToString(types_to_download) | ||
<< " added; calling ConfigureDataTypes"; | ||
// TODO(sync): crbug.com/137550. | ||
// It's dangerous to configure types that have progress markers. Types with |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters