Code

Brave syncer#2010

Code

Merged

darkdh merged 73 commits intomasterbrave/brave-core:masterfrom brave-syncerbrave/brave-core:brave-syncerCopy head branch name to clipboardAug 20, 2019

+4,684-4,769

Commits

Commits on Aug 19, 2019

• Make browser_sync::ProfileSyncService a brave_sync::SyncMessageHandler

  Show description for c423779
  darkdh

  committed
  c423779

  Copy full SHA for c423779

• Fixed build on Linux

  

  AlexeyBarabash

  authored and

  darkdh

  committed
  5d9fd40

  Copy full SHA for 5d9fd40

• Upgrade to 74.0.3729.75

  darkdh

  committed
  d08cd5e

  Copy full SHA for d08cd5e

• Pass icon data

  

  AlexeyBarabash

  authored and

  darkdh

  committed
  5371a9b

  Copy full SHA for 5371a9b

• Migrate from legacy sync

  darkdh

  committed
  e7155d4

  Copy full SHA for e7155d4

• Introduce IsFirstLoadedFavicon to avoid favicon loading trigged sending duplicate records

  darkdh

  committed
  2b431d6

  Copy full SHA for 2b431d6

• Remove unused code

  darkdh

  committed
  22e770b

  Copy full SHA for 22e770b

• Fix Reset bug and prevent shutdown sync thread hanging

  darkdh

  committed
  be43397

  Copy full SHA for be43397

• Implement OnSaveBookmarkOrder from #2326

  darkdh

  committed
  78e0d85

  Copy full SHA for 78e0d85

• Redefine order calculation to be simply parent_order + index_in_parent

  Show description for 372552b
  darkdh

  committed
  372552b

  Copy full SHA for 372552b

• Fix wrong sync code crash

  darkdh

  committed
  8896428

  Copy full SHA for 8896428

• Subclass browser_sync::ProfileSyncService

  darkdh

  committed
  8ca0675

  Copy full SHA for 8ca0675

• Fix DCHECK failure because of lacking permanent nodes order when

  Show description for 4972a86
  darkdh

  committed
  4972a86

  Copy full SHA for 4972a86

• Handle same index from different devices by order

  darkdh

  committed
  6463250

  Copy full SHA for 6463250

• Set user-chosen sync type only when first time sync setup or migrated

  Show description for 05731ec
  darkdh

  committed
  05731ec

  Copy full SHA for 05731ec

• Using MigratedBookmarksVersion >= 2 to check legacy sync migration status so

  Show description for 4f6ed56
  darkdh

  committed
  4f6ed56

  Copy full SHA for 4f6ed56

• Stub out Control Types

  darkdh

  committed
  73627bb

  Copy full SHA for 73627bb

• Fix index calculation when applying remote records

  darkdh

  committed
  2d4662f

  Copy full SHA for 2d4662f

• Migrate BraveSyncServiceTest

  darkdh

  committed
  5d4d8c2

  Copy full SHA for 5d4d8c2

• Add test for SyncerHelper

  Show description for 57cf686
  darkdh

  committed
  57cf686

  Copy full SHA for 57cf686

• C75.0.3770.38 Upgrade

  darkdh

  committed
  a766cdd

  Copy full SHA for a766cdd

• Dont send bookmarks until chain is created. Re-do of brave-core pr#2016

  

  AlexeyBarabash

  authored and

  darkdh

  committed
  ed60929

  Copy full SHA for ed60929

• Force DEVICE_INFO to have nudge cycles

  

  AlexeyBarabash

  authored and

  darkdh

  committed
  6e31e37

  Copy full SHA for 6e31e37

• Register brave_sync pref with chromium sync

  darkdh

  committed
  1db950a

  Copy full SHA for 1db950a

• Consolidate BraveSyncServiceTest

  darkdh

  committed
  bd689d0

  Copy full SHA for bd689d0

• Remove manually disable field trail feature

  Show description for c5fbe1f
  darkdh

  committed
  c5fbe1f

  Copy full SHA for c5fbe1f

• lint fix

  darkdh

  committed
  5b0f830

  Copy full SHA for 5b0f830

• Move BraveSyncClient to BraveProfileSyncService

  darkdh

  committed
  a524251

  Copy full SHA for a524251

• Android build fix

  Show description for 1e55ab6
  darkdh

  committed
  1e55ab6

  Copy full SHA for 1e55ab6

• Replace brave_sync::BraveSyncService::is_enabled() with switches::IsBraveSyncAllowedByFlag()

  darkdh

  committed
  e2617dc

  Copy full SHA for e2617dc

• Window release build deps fix

  darkdh

  committed
  bf1becb

  Copy full SHA for bf1becb

• single dep encapsulation

  darkdh

  committed
  902017f

  Copy full SHA for 902017f

• IsSyncAllowedByFlag chromium_src override

  darkdh

  committed
  2b2e2e5

  Copy full SHA for 2b2e2e5

• remove GetAsBraveProfileSyncServiceForProfile and use ENABLE_BRAVE_SYNC in chromium

  darkdh

  committed
  baf9003

  Copy full SHA for baf9003

• friend BraveProfileSyncService

  darkdh

  committed
  5591700

  Copy full SHA for 5591700

• Using SyncEngineHost to avoid storing poll/nudge delegates

  darkdh

  committed
  23fdeed

  Copy full SHA for 23fdeed

• Move brave_sync::RegisterProfilePrefs to brave::RegisterProfilePrefs

  darkdh

  committed
  0ff789f

  Copy full SHA for 0ff789f

• Chromium override SyncerProtoUtil

  darkdh

  committed
  d970cad

  Copy full SHA for d970cad

• Update 75.0.3770.90 patch

  darkdh

  committed
  38b42cf

  Copy full SHA for 38b42cf

• clean up patches

  darkdh

  committed
  48d6aaf

  Copy full SHA for 48d6aaf

• add guards for ENABLE_BRAVE_SYNC

  

  bridiver

  authored and

  darkdh

  committed
  f3f381c

  Copy full SHA for f3f381c

• Fixed Linux build

  

  AlexeyBarabash

  authored and

  darkdh

  committed
  f4a013b

  Copy full SHA for f4a013b

• BraveProfileSyncService => BraveProfileSyncServiceImpl; BraveProfileSyncServiceExports => BraveProfileSyncService

  

  AlexeyBarabash

  authored and

  darkdh

  committed
  60d93e0

  Copy full SHA for 60d93e0

• Ignore records from ourselves

  

  AlexeyBarabash

  authored and

  darkdh

  committed
  3fbacc7

  Copy full SHA for 3fbacc7

• Send records after at least 30 sec after chain creation

  

  AlexeyBarabash

  authored and

  darkdh

  committed
  2176464

  Copy full SHA for 2176464

• Fix tests for send records after at least 30 sec after chain creation

  

  AlexeyBarabash

  authored and

  darkdh

  committed
  b0c8c49

  Copy full SHA for b0c8c49

• Patches for attach/detach behaviour for WriteTransaction

  

  AlexeyBarabash

  authored and

  darkdh

  committed
  ee2fbf5

  Copy full SHA for ee2fbf5

• Sort bookmarks in BookmarkChangeProcessor::ApplyChangesFromSyncModel and update corresponding sync nodes

  

  AlexeyBarabash

  authored and

  darkdh

  committed
  0aad976

  Copy full SHA for 0aad976

• Update DEPS to contain "Ignore records from SQS which where seen in S3"

  

  AlexeyBarabash

  authored and

  darkdh

  committed
  eb2dd0b

  Copy full SHA for eb2dd0b

• Use title or customeTitle, non empty value

  

  AlexeyBarabash

  authored and

  darkdh

  committed
  5eecbd2

  Copy full SHA for 5eecbd2

• Fix for crash with bookmark position from older sync client (android)

  

  AlexeyBarabash

  authored and

  darkdh

  committed
  a04cb32

  Copy full SHA for a04cb32

• Update 76.0.3809.62 patches

  darkdh

  committed
  0f79073

  Copy full SHA for 0f79073

• Remove BRAVE_SHOULD_SHOW_SIGNIN_PROMO_SHORT_CIRCUIT_TO_FALSE and lint fix

  darkdh

  committed
  1338103

  Copy full SHA for 1338103

• Fix enable_brave_sync=false

  Show description for 7fcee9d
  darkdh

  committed
  7fcee9d

  Copy full SHA for 7fcee9d

• Check DISABLE_REASON_ENTERPRISE_POLICY in ShouldShowSignInPromo and fix GetDisableReasons unittest

  darkdh

  committed
  c3fc745

  Copy full SHA for c3fc745

• Passive resend unconfirmed records

  darkdh

  committed
  97d0eca

  Copy full SHA for 97d0eca

• Sync reset reenable (#3038)

  darkdh

  committed
  91e5d05

  Copy full SHA for 91e5d05

• Exponentials resend periods (#2986)

  Show description for 9677876
  darkdh

  committed
  9677876

  Copy full SHA for 9677876

• Native code for bookmark order calculations

  Show description for 4b2b835
  

  AlexeyBarabash

  authored and

  darkdh

  committed
  4b2b835

  Copy full SHA for 4b2b835

• Testcases for native bookmark order calculations

  Show description for 1c2ba0a
  

  AlexeyBarabash

  authored and

  darkdh

  committed
  1c2ba0a

  Copy full SHA for 1c2ba0a

• Bookmarks positioning by order strings

  

  AlexeyBarabash

  authored and

  darkdh

  committed
  412e408

  Copy full SHA for 412e408

• Updated testcases for positioning by orders

  

  AlexeyBarabash

  authored and

  darkdh

  committed
  e1104e2

  Copy full SHA for e1104e2

• In case of equal orders use object_id

  

  AlexeyBarabash

  authored and

  darkdh

  committed
  5cab8ba

  Copy full SHA for 5cab8ba

• Test case for use object_id when orders are equal

  

  AlexeyBarabash

  authored and

  darkdh

  committed
  4969766

  Copy full SHA for 4969766

• Ignore move events during extensive changes

  

  AlexeyBarabash

  authored and

  darkdh

  committed
  6eef9c2

  Copy full SHA for 6eef9c2

• Network changes and Reset handling

  darkdh

  committed
  6636c1d

  Copy full SHA for 6636c1d

• Using UniquePosition for bookmark order by position_in_parent

  Show description for b376e3f
  darkdh

  committed
  b376e3f

  Copy full SHA for b376e3f

• Maintain SyncEntityInfo in bookmark node's meta info for legacy sync

  Show description for ce62ff9
  darkdh

  committed
  ce62ff9

  Copy full SHA for ce62ff9

• Review Feedback (1)

  Show description for 99b97f5
  darkdh

  committed
  99b97f5

  Copy full SHA for 99b97f5

• Review Feedback (2)

  Show description for 220d604
  darkdh

  committed
  220d604

  Copy full SHA for 220d604

• Use WaitableEvent::TimedWait as fail-safe

  darkdh

  committed
  99f29b6

  Copy full SHA for 99f29b6

• Review feedback (3)

  Show description for 8b24310
  darkdh

  committed
  8b24310

  Copy full SHA for 8b24310

• Do not send meta info until all platforms support necessary chromium

  Show description for 42c5c31
  darkdh

  committed
  42c5c31

  Copy full SHA for 42c5c31