Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cr116 follow-up] Disables kOptimizationGuideFetchingForSRP feature. #19457

Merged
merged 1 commit into from
Jul 28, 2023
Merged

[cr116 follow-up] Disables kOptimizationGuideFetchingForSRP feature. #19457

merged 1 commit into from
Jul 28, 2023

Conversation

mkarolin
Copy link
Collaborator

Fixes brave/brave-browser#31929

Chromium change:

https://source.chromium.org/chromium/chromium/src/+/f170d2e1e97d960a4535d4222076ec684682470a

commit f170d2e1e97d960a4535d4222076ec684682470a
Author: Catherine Liu [email protected]
Date: Wed Jul 19 00:44:38 2023 +0000

Killswitch for SRP context fetches.

Bug: 1463073

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@mkarolin mkarolin requested a review from a team as a code owner July 27, 2023 17:50
@mkarolin mkarolin self-assigned this Jul 27, 2023
@github-actions github-actions bot added CI/run-network-audit Run network-audit CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux) labels Jul 27, 2023
@mkarolin mkarolin mentioned this pull request Jul 27, 2023
Merged
25 tasks
@mkarolin
[cr116 follow-up] Disables kOptimizationGuideFetchingForSRP feature.
dd8dbb9 
Chromium change:

https://source.chromium.org/chromium/chromium/src/+/f170d2e1e97d960a4535d4222076ec684682470a

commit f170d2e1e97d960a4535d4222076ec684682470a
Author: Catherine Liu <[email protected]>
Date:   Wed Jul 19 00:44:38 2023 +0000

    Killswitch for SRP context fetches.

    Bug: 1463073
@mkarolin mkarolin force-pushed the maxk-disable-kOptimizationGuideFetchingForSRP branch from 22237d9 to dd8dbb9 Compare July 27, 2023 19:34
@mkarolin mkarolin merged commit 30a9304 into master Jul 28, 2023
@mkarolin mkarolin deleted the maxk-disable-kOptimizationGuideFetchingForSRP branch July 28, 2023 13:51
@mkarolin mkarolin added this to the 1.58.x - Nightly milestone Jul 28, 2023
@mkarolin mkarolin mentioned this pull request Jul 28, 2023
Merged
25 tasks
mkarolin added a commit that referenced this pull request Aug 3, 2023
@mkarolin
Merge pull request #19457 from brave/maxk-disable-kOptimizationGuideF…
1010fc4 
…etchingForSRP

[cr116 follow-up] Disables kOptimizationGuideFetchingForSRP feature.
kjozwiak pushed a commit that referenced this pull request Aug 8, 2023
@mkarolin @bridiver
@goodov @samartnik @atuchin-m @sangwoo108 @mherrmann
Upgrade from Chromium 115 to Chromium 116 + Rust changes (uplift to 1…
6b9032a 
….57.x). (#19447)

* Merge pull request #18955 from brave/cargo-rustc-cr115

Convert to rust_static_lib

* fix patch to exclude compiler builtins for linux arm64 (#19118)

don't use compiler_builtins for linux arm64 because the prebuilt library doesn't exist yet in upstream

* Merge pull request #19125 from brave/issues/31415

Use Brave forked version of futures-retry

* Merge pull request #19132 from brave/win-prebuilt-fix

add win arm64 back in temporarily until we get the llvm update with t…

* Merge pull request #19232 from brave/rust-dep-fixup

Rust dep fixup

* Merge pull request #19300 from brave/rust-dep-cleanup-2

Remove remaining dependencies using download_rust_deps

* Merge pull request #19320 from brave/rust-dep-cleanup-3

* Merge pull request #19339 from brave/win-rust-asan-fix

upstream patch https://chromium-review.googlesource.com/c/chromium/sr…

* Fix __rust_dealloc on Windows. (#19116)

* Merge pull request #19322 from brave/audit-branding-fix

audit_deps needs branding for some reason

* Merge pull request #19426 from brave/rust-unsafe-fn

* Merge pull request #18808 from brave/cr116

Upgrade from Chromium 115 to Chromium 116

* Merge pull request #19453 from brave/android_text_view_id_conflict_fix

[C116] [Android] Fix for the `text_view` id conflict

* Fix loading.desktop.brave after cr116 (#19450)

* Fix loading.desktop.brave after cr116
* Fix lint errors

* Merge pull request #19455 from brave/maxk-fix-narrow-settings-menu

[cr116 follow-up] Fixes narrow settings menu button.

* Merge pull request #19457 from brave/maxk-disable-kOptimizationGuideFetchingForSRP

[cr116 follow-up] Disables kOptimizationGuideFetchingForSRP feature.

* Merge pull request #19458 from brave/maxk-fix-brave-toolbar

[cr116 follow-up] Fixes toolbar buttons misalignment.

* Update padding after brave toolbar is initialized (#19484)

As we're not updating padding during in the middle of initialization,
we should do it after it finishes.

* Fix broken on-demand updates on Windows (#19469)

---------

Co-authored-by: Brian Johnson <[email protected]>
Co-authored-by: Aleksey Khoroshilov <[email protected]>
Co-authored-by: samartnik <[email protected]>
Co-authored-by: Mikhail <[email protected]>
Co-authored-by: Sangwoo Ko <[email protected]>
Co-authored-by: Michael Herrmann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iefremov iefremov iefremov approved these changes

Assignees

@mkarolin mkarolin

Labels
CI/run-network-audit Run network-audit CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux)
Projects
None yet
Milestone
1.58.x - Release
Development

Successfully merging this pull request may close these issues.

[cr116 follow up] Disable kOptimizationGuideFetchingForSRP feature.
2 participants
@mkarolin @iefremov