Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cr116 follow up] Disable kOptimizationGuideFetchingForSRP feature. #31929

Closed
mkarolin opened this issue Jul 27, 2023 · 0 comments · Fixed by brave/brave-core#19457
Closed

[cr116 follow up] Disable kOptimizationGuideFetchingForSRP feature. #31929

mkarolin opened this issue Jul 27, 2023 · 0 comments · Fixed by brave/brave-core#19457
Assignees
@mkarolin
Labels
dev-concern OS/Android Fixes related to Android browser functionality OS/Desktop QA/No release-notes/exclude
Milestone
1.57.x - Release

Comments

@mkarolin
Copy link
Contributor

We disable OptimizationGuide and all related features.

This one, added in 116.0.5845.51 bump also needs to be disabled:

// Killswitch for fetching on search results from a remote Optimization Guide
// Service.
BASE_FEATURE(kOptimizationGuideFetchingForSRP,
             "OptimizationHintsFetchingSRP",
             base::FEATURE_ENABLED_BY_DEFAULT);

cc: @pes10k @fmarier
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkarolin mkarolin

Labels
dev-concern OS/Android Fixes related to Android browser functionality OS/Desktop QA/No release-notes/exclude
Projects
None yet
Milestone
1.57.x - Release
Development

Successfully merging a pull request may close this issue.

[cr116 follow-up] Disables kOptimizationGuideFetchingForSRP feature. brave/brave-core
2 participants
@mkarolin @brave-builds