Merge pull request #19457 from brave/maxk-disable-kOptimizationGuideF…

…etchingForSRP [cr116 follow-up] Disables kOptimizationGuideFetchingForSRP feature.
brave · Aug 3, 2023 · 1010fc4 · 1010fc4
1 parent 2b084b9
commit 1010fc4
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 0 deletions.
diff --git a/app/brave_main_delegate_browsertest.cc b/app/brave_main_delegate_browsertest.cc
@@ -237,6 +237,7 @@ IN_PROC_BROWSER_TEST_F(BraveMainDelegateBrowserTest, DisabledFeatures) {
     &optimization_guide::features::kRemoteOptimizationGuideFetching,
     &optimization_guide::features::
         kRemoteOptimizationGuideFetchingAnonymousDataConsent,
+    &optimization_guide::features::kOptimizationGuideFetchingForSRP,
     &page_image_service::kImageService,
     &page_image_service::kImageServiceSuggestPoweredImages,
 #if !BUILDFLAG(IS_ANDROID)

diff --git a/chromium_src/components/optimization_guide/core/optimization_guide_features.cc b/chromium_src/components/optimization_guide/core/optimization_guide_features.cc
@@ -15,6 +15,7 @@ OVERRIDE_FEATURE_DEFAULT_STATES({{
     {kRemoteOptimizationGuideFetching, base::FEATURE_DISABLED_BY_DEFAULT},
     {kRemoteOptimizationGuideFetchingAnonymousDataConsent,
      base::FEATURE_DISABLED_BY_DEFAULT},
+    {kOptimizationGuideFetchingForSRP, base::FEATURE_DISABLED_BY_DEFAULT},
 }});
 
 }  // namespace features

diff --git a/test/filters/unit_tests.filter b/test/filters/unit_tests.filter
@@ -367,6 +367,10 @@
 # This test fails because we disable page_image_service::kImageService feature.
 -NewTabPageModulesTest.MakeModuleIdNames
 
+# These tests fail because we disable
+# optimization_guide::features::kOptimizationGuideFetchingForSRP
+-ChromeHintsManagerFetchingTest.HintsFetched_*
+
 # Tests below this point have not been diagnosed or had issues created yet.
 -AboutFlagsHistogramTest.*
 -AboutFlagsTest.*