Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move remaining rust deps into third_party/rust #19320

Merged
merged 3 commits into from
Jul 18, 2023
Merged

Move remaining rust deps into third_party/rust #19320

merged 3 commits into from
Jul 18, 2023

Conversation

bridiver
Copy link
Collaborator

@bridiver bridiver commented Jul 17, 2023 •
edited
Loading

Resolves brave/brave-browser#31693

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@bridiver bridiver requested review from a team as code owners July 17, 2023 22:57
@github-actions github-actions bot added the CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) label Jul 17, 2023
@bridiver bridiver changed the title Rust dep cleanup 3 Move remaining rust deps into third_party/rust Jul 17, 2023
@bridiver bridiver requested a review from a team July 17, 2023 23:00
@bridiver bridiver force-pushed the rust-dep-cleanup-3 branch from 6014080 to 6d01607 Compare July 17, 2023 23:07
@bridiver bridiver force-pushed the rust-dep-cleanup-3 branch from abcfebd to 769c537 Compare July 18, 2023 01:47
mkarolin
mkarolin approved these changes Jul 18, 2023
View reviewed changes
Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DEPS++

@bridiver bridiver merged commit c7747ff into master Jul 18, 2023
@bridiver bridiver deleted the rust-dep-cleanup-3 branch July 18, 2023 12:59
@github-actions github-actions bot added this to the 1.58.x - Nightly milestone Jul 18, 2023
mkarolin pushed a commit that referenced this pull request Jul 20, 2023
@bridiver @mkarolin
Merge pull request #19320 from brave/rust-dep-cleanup-3
7533c7c
@mkarolin mkarolin mentioned this pull request Jul 20, 2023
Closed
25 tasks
@mkarolin mkarolin mentioned this pull request Jul 27, 2023
Merged
25 tasks
mkarolin pushed a commit that referenced this pull request Aug 3, 2023
@bridiver @mkarolin
Merge pull request #19320 from brave/rust-dep-cleanup-3
f27b203
kjozwiak pushed a commit that referenced this pull request Aug 8, 2023
@mkarolin @bridiver
@goodov @samartnik @atuchin-m @sangwoo108 @mherrmann
Upgrade from Chromium 115 to Chromium 116 + Rust changes (uplift to 1…
6b9032a 
….57.x). (#19447)

* Merge pull request #18955 from brave/cargo-rustc-cr115

Convert to rust_static_lib

* fix patch to exclude compiler builtins for linux arm64 (#19118)

don't use compiler_builtins for linux arm64 because the prebuilt library doesn't exist yet in upstream

* Merge pull request #19125 from brave/issues/31415

Use Brave forked version of futures-retry

* Merge pull request #19132 from brave/win-prebuilt-fix

add win arm64 back in temporarily until we get the llvm update with t…

* Merge pull request #19232 from brave/rust-dep-fixup

Rust dep fixup

* Merge pull request #19300 from brave/rust-dep-cleanup-2

Remove remaining dependencies using download_rust_deps

* Merge pull request #19320 from brave/rust-dep-cleanup-3

* Merge pull request #19339 from brave/win-rust-asan-fix

upstream patch https://chromium-review.googlesource.com/c/chromium/sr…

* Fix __rust_dealloc on Windows. (#19116)

* Merge pull request #19322 from brave/audit-branding-fix

audit_deps needs branding for some reason

* Merge pull request #19426 from brave/rust-unsafe-fn

* Merge pull request #18808 from brave/cr116

Upgrade from Chromium 115 to Chromium 116

* Merge pull request #19453 from brave/android_text_view_id_conflict_fix

[C116] [Android] Fix for the `text_view` id conflict

* Fix loading.desktop.brave after cr116 (#19450)

* Fix loading.desktop.brave after cr116
* Fix lint errors

* Merge pull request #19455 from brave/maxk-fix-narrow-settings-menu

[cr116 follow-up] Fixes narrow settings menu button.

* Merge pull request #19457 from brave/maxk-disable-kOptimizationGuideFetchingForSRP

[cr116 follow-up] Disables kOptimizationGuideFetchingForSRP feature.

* Merge pull request #19458 from brave/maxk-fix-brave-toolbar

[cr116 follow-up] Fixes toolbar buttons misalignment.

* Update padding after brave toolbar is initialized (#19484)

As we're not updating padding during in the middle of initialization,
we should do it after it finishes.

* Fix broken on-demand updates on Windows (#19469)

---------

Co-authored-by: Brian Johnson <[email protected]>
Co-authored-by: Aleksey Khoroshilov <[email protected]>
Co-authored-by: samartnik <[email protected]>
Co-authored-by: Mikhail <[email protected]>
Co-authored-by: Sangwoo Ko <[email protected]>
Co-authored-by: Michael Herrmann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkarolin mkarolin mkarolin approved these changes

@antonok-edm antonok-edm antonok-edm approved these changes

@DJAndries DJAndries DJAndries approved these changes

Assignees

@bridiver bridiver

Labels
CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps)
Projects
None yet
Milestone
1.58.x - Release
Development

Successfully merging this pull request may close these issues.

move remaining rust deps into third_party/rust
4 participants
@bridiver @DJAndries @antonok-edm @mkarolin