Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move remaining rust deps into third_party/rust #31693

Closed
bridiver opened this issue Jul 18, 2023 · 0 comments · Fixed by brave/brave-core#19320
Closed

move remaining rust deps into third_party/rust #31693

bridiver opened this issue Jul 18, 2023 · 0 comments · Fixed by brave/brave-core#19320
Assignees
@bridiver
Labels
dev-concern OS/Android Fixes related to Android browser functionality OS/Desktop QA/No release-notes/exclude
Milestone
1.57.x - Release

Comments

@bridiver
Copy link
Contributor

move remaining rust deps into third_party/rust so gnrt gen can correctly determine deps without copying them into third_party.toml
@bridiver bridiver added OS/Android Fixes related to Android browser functionality OS/Desktop labels Jul 18, 2023
@bridiver bridiver self-assigned this Jul 18, 2023
@bridiver bridiver mentioned this issue Jul 18, 2023
Merged
25 tasks
@brave-builds brave-builds added this to the 1.58.x - Nightly milestone Jul 18, 2023
This was referenced Jul 20, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bridiver bridiver

Labels
dev-concern OS/Android Fixes related to Android browser functionality OS/Desktop QA/No release-notes/exclude
Projects
None yet
Milestone
1.57.x - Release
Development

Successfully merging a pull request may close this issue.

Move remaining rust deps into third_party/rust brave/brave-core
2 participants
@bridiver @brave-builds