Split precompile constants out of individual modules #2081 #2085

Ayushdubey86 · 2025-02-15T11:13:00Z

This should do it, not much sure about indentations though. do let me know if it requires any further change @rakita!
pr being for this issue

i have addressed this issue as well
"This does not look great. Can you create one bls12_381_const.rs file, scan all bls12 files for constant and move them to that file?"

…Individual-Modules-bluealloy#2081

codspeed-hq · 2025-02-15T11:35:35Z

CodSpeed Performance Report

Merging #2085 will not alter performance

_{Comparing Ayushdubey86:Split-Precompile-Constants-out-of-Individual-Modules-#2081 (ec26a86) with main (c525b5e)}

Summary

✅ 8 untouched benchmarks

crates/precompile/src/bls12_381/bls12_381_const.rs

crates/precompile/src/bls12_381/g2_msm.rs

…Individual-Modules-bluealloy#2081

crates/precompile/src/bls12_381_const.rs

This reverts commit 02c9b67.

Ayushdubey86 added 16 commits February 15, 2025 01:00

Update bls12_381.rs

17d3350

Merge branch 'bluealloy:main' into Split-Precompile-Constants-out-of-…

4e3849a

…Individual-Modules-bluealloy#2081

Update g1.rs

6723031

Update g1_add.rs

771feed

Update g1.rs

46393d7

Update g1_msm.rs

b3a8830

Update g2.rs

65b91b2

Update g2_add.rs

06b1abc

Update g2_msm.rs

8b440c7

Update map_fp_to_g1.rs

45d2b57

Update map_fp2_to_g2.rs

2aa936b

Update msm.rs

92752f8

Update pairing.rs

91e4e49

Update utils.rs

7170956

Add files via upload

e14174b

Update bls12_381.rs

5ed8fb4

Ayushdubey86 mentioned this pull request Feb 16, 2025

Split Precompile Constants out of Individual Modules #2081

Closed

rakita reviewed Feb 16, 2025

View reviewed changes

crates/precompile/src/bls12_381/bls12_381_const.rs Outdated Show resolved Hide resolved

rakita reviewed Feb 16, 2025

View reviewed changes

crates/precompile/src/bls12_381/bls12_381_const.rs Outdated Show resolved Hide resolved

rakita reviewed Feb 16, 2025

View reviewed changes

crates/precompile/src/bls12_381/g2_msm.rs Outdated Show resolved Hide resolved

Ayushdubey86 added 9 commits February 17, 2025 10:53

Merge branch 'bluealloy:main' into Split-Precompile-Constants-out-of-…

49a604e

…Individual-Modules-bluealloy#2081

Update bls12_381_const.rs

7e45d7c

Update g1.rs

88eb122

Update g1_add.rs

fa79045

Update g1_msm.rs

5a3f7d1

Update g2.rs

9bf0f5f

Update g2_add.rs

5f414ea

Update g2_msm.rs

96da3a1

Update map_fp2_to_g2.rs

da24a29

Ayushdubey86 added 22 commits February 19, 2025 11:36

Update g1_msm.rs

e13e418

Update g2.rs

25d447d

Update g1_add.rs

7547528

Update g1_add.rs

80fbd53

Update g1_msm.rs

7af1926

Update g1_add.rs

708bbc0

Update g2_msm.rs

72376e6

Update map_fp2_to_g2.rs

629b070

Update map_fp_to_g1.rs

b280c35

Update utils.rs

ca89ecf

Update bls12_381.rs

a9b0845

Update g1_add.rs

1149445

Update g1_msm.rs

681a35b

Update g2_msm.rs

451581f

Update g2_msm.rs

b4931e5

Update g2_msm.rs

c9b4001

Update bls12_381_const.rs

2ad5ded

Update lib.rs

22f9e48

Update map_fp2_to_g2.rs

3643dce

Update map_fp2_to_g2.rs

f6a1e80

Update map_fp2_to_g2.rs

6fff639

Update map_fp2_to_g2.rs

ec26a86

rakita merged commit 02c9b67 into bluealloy:main Feb 19, 2025
28 checks passed

This was referenced Feb 18, 2025

chore: release #2057

Open

chore: release jumpkip/revm#1

Open

holiman reviewed Feb 20, 2025

View reviewed changes

crates/precompile/src/bls12_381_const.rs Show resolved Hide resolved

github-actions bot mentioned this pull request Feb 20, 2025

chore: release Ayushdubey86/revm#7

Open

mattsse added a commit that referenced this pull request Feb 20, 2025

Revert "chore: Split blst constants out to individual file #2085"

a26f7e6

This reverts commit 02c9b67.

mattsse mentioned this pull request Feb 20, 2025

Revert "Split precompile constants out of individual modules #2081" #2101

Closed

rakita mentioned this pull request Feb 20, 2025

fix(blst): Fix wrong constants value and usage #2102

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Split precompile constants out of individual modules #2081 #2085

Split precompile constants out of individual modules #2081 #2085

Ayushdubey86 commented Feb 15, 2025 •

edited

Loading

codspeed-hq bot commented Feb 15, 2025 •

edited

Loading

Split precompile constants out of individual modules #2081 #2085

Split precompile constants out of individual modules #2081 #2085

Conversation

Ayushdubey86 commented Feb 15, 2025 • edited Loading

codspeed-hq bot commented Feb 15, 2025 • edited Loading

CodSpeed Performance Report

Merging #2085 will not alter performance

Summary

Ayushdubey86 commented Feb 15, 2025 •

edited

Loading

codspeed-hq bot commented Feb 15, 2025 •

edited

Loading