Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Split precompile constants out of individual modules #2081" #2101

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Feb 20, 2025

Reverts #2085

this change introduced a bug, we should start over here and do it right

Copy link

codspeed-hq bot commented Feb 20, 2025

CodSpeed Performance Report

Merging #2101 will not alter performance

Comparing revert-2085-Split-Precompile-Constants-out-of-Individual-Modules-#2081 (a26f7e6) with main (02c9b67)

Summary

✅ 8 untouched benchmarks

@rakita
Copy link
Member

rakita commented Feb 20, 2025

Will close this as bugs have been fixed here: #2102 and CI for prague is enabled

@rakita rakita closed this Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants