-
Notifications
You must be signed in to change notification settings - Fork 623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split Precompile Constants out of Individual Modules #2081
Comments
This makes sense |
Ayushdubey86
added a commit
to Ayushdubey86/revm
that referenced
this issue
Feb 15, 2025
whomsoever is free, can they check out this pr! |
Ayushdubey86
added a commit
to Ayushdubey86/revm
that referenced
this issue
Feb 17, 2025
Ayushdubey86
added a commit
to Ayushdubey86/revm
that referenced
this issue
Feb 18, 2025
Ayushdubey86
added a commit
to Ayushdubey86/revm
that referenced
this issue
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
revm-precompile
currently places BLS12-381 precompiles behind theblst
feature flag. This restricts everything in thebls12_381
module to onlystd
environments. This ticket is to hoist the constants (for example, bls12-381 g1 addition constants) into a module accessible from ano_std
environment.Constants Module Approach
One option to split these out is to move all the constants into a
consts.rs
module insidebls12_381
that is not behind theblst
feature flag.Then, remove the
blst
feature flag on the wholebls12_381
module and place it over only the precompiles within thebls12_381
module.Effectively, from a
no_std
environment the api would look like:And from an
std
environment, the api would look like:Motivation
Downstream consumers of
revm
userevm-precompile
to accelerate various precompiles for fault proof programs. For example, in kona, the BLS12-381 precompiles are accelerated. Doing so, requires the use of constants like input length, base fees, and precompile addresses that are already defined in revm, but are inaccessible due tokona-client
having a strictno_std
requirement.The text was updated successfully, but these errors were encountered: