Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] cherrypick #597 and #598 to stable-2 branch #599

Conversation

saito-hideki
Copy link
Collaborator

SUMMARY

Merge the following two PRs to stable-2 as a cherrypick

ISSUE TYPE
  • Backport Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION
None

 Remove comment from fstab entry on updating.

SUMMARY
Fix ansible-collections#595.
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
ansible.posix.mount
ADDITIONAL INFORMATION

Reviewed-by: Hideki Saito <[email protected]>
Reviewed-by: Vladimir Botka <[email protected]>
[Breaking Change] [firewalld] Change type of icmp_block_inversion option from str to bool

SUMMARY
Changed the type of icmp_block_inversion option from str to bool

Fixes ansible-collections#586

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

ansible.posix.firewalld

ADDITIONAL INFORMATION
Related  ansible-collections#582 and ansible-collections#584

Reviewed-by: Adam Miller <[email protected]>
Reviewed-by: Andrew Klychkov <[email protected]>
@saito-hideki saito-hideki added backport backport request for stable branch stable-2 Issue or pull request for stable-2 labels Dec 3, 2024
Copy link
Contributor

@saito-hideki saito-hideki self-assigned this Dec 3, 2024
@saito-hideki saito-hideki marked this pull request as ready for review December 3, 2024 03:36
@saito-hideki saito-hideki added the mergeit Gate PR in Zuul CI label Dec 3, 2024
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/e9b59668dbf749bf9640350025016493

✔️ ansible-galaxy-importer SUCCESS in 4m 05s
✔️ build-ansible-collection SUCCESS in 5m 25s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit e8fc89f into ansible-collections:stable-2 Dec 3, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport backport request for stable branch mergeit Gate PR in Zuul CI stable-2 Issue or pull request for stable-2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant