Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Breaking Change] [firewalld] Need to change the type of the icmp_block_inversion option from str to bool #586

Closed
saito-hideki opened this issue Oct 30, 2024 · 0 comments · Fixed by #598
Closed

[Breaking Change] [firewalld] Need to change the type of the icmp_block_inversion option from str to bool #586

saito-hideki opened this issue Oct 30, 2024 · 0 comments · Fixed by #598
Assignees
@saito-hideki
Labels
feature This issue/PR relates to a feature request. verified This issue has been verified/reproduced by maintainer

Comments

@saito-hideki
Copy link
Collaborator

SUMMARY

Towards the release of version 2.0.0, we should change the type of the icmp_block_inversion option from str to bool.

ISSUE TYPE
  • Feature Idea
COMPONENT NAME
  • ansible.posix.firewalld
ADDITIONAL INFORMATION
@saito-hideki saito-hideki self-assigned this Oct 30, 2024
@saito-hideki saito-hideki added feature This issue/PR relates to a feature request. verified This issue has been verified/reproduced by maintainer labels Oct 30, 2024
saito-hideki added a commit to saito-hideki/ansible.posix that referenced this issue Nov 28, 2024
@saito-hideki
Change type of icmp_block_inversion option from str to bool
e47c26d 
* Fixes ansible-collections#586

Signed-off-by: Hideki Saito <[email protected]>
@saito-hideki saito-hideki mentioned this issue Nov 28, 2024
Merged
softwarefactory-project-zuul bot added a commit that referenced this issue Dec 2, 2024
@softwarefactory-project-zuul
Merge pull request #598 from saito-hideki/issue/586
f632fad 
[Breaking Change] [firewalld] Change type of icmp_block_inversion option from str to bool

SUMMARY
Changed the type of icmp_block_inversion option from str to bool

Fixes #586

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

ansible.posix.firewalld

ADDITIONAL INFORMATION
Related  #582 and #584

Reviewed-by: Adam Miller <[email protected]>
Reviewed-by: Andrew Klychkov <[email protected]>
saito-hideki pushed a commit to saito-hideki/ansible.posix that referenced this issue Dec 3, 2024
@softwarefactory-project-zuul @saito-hideki
Merge pull request ansible-collections#598 from saito-hideki/issue/586
ce72b7b 
[Breaking Change] [firewalld] Change type of icmp_block_inversion option from str to bool

SUMMARY
Changed the type of icmp_block_inversion option from str to bool

Fixes ansible-collections#586

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

ansible.posix.firewalld

ADDITIONAL INFORMATION
Related  ansible-collections#582 and ansible-collections#584

Reviewed-by: Adam Miller <[email protected]>
Reviewed-by: Andrew Klychkov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@saito-hideki saito-hideki

Labels
feature This issue/PR relates to a feature request. verified This issue has been verified/reproduced by maintainer
Projects
None yet
Milestone
No milestone
1 participant
@saito-hideki