[Breaking Change] [firewalld] Change type of icmp_block_inversion option from str to bool #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 3m 54s |
* Fixes ansible-collections#586 Signed-off-by: Hideki Saito <[email protected]>
saito-hideki
force-pushed
the
issue/586
branch
from
e47c26d to
6175a50
Compare
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 27s |
maxamillion
approved these changes
Nov 28, 2024
|
@maxamillion @Andersson007 Thank you for your review :) |
|
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 3m 25s |
softwarefactory-project-zuul
bot
merged commit f632fad
into
ansible-collections:main
45 checks passed
saito-hideki
pushed a commit
to saito-hideki/ansible.posix
that referenced
this pull request
Dec 3, 2024
[Breaking Change] [firewalld] Change type of icmp_block_inversion option from str to bool SUMMARY Changed the type of icmp_block_inversion option from str to bool Fixes ansible-collections#586 ISSUE TYPE Bugfix Pull Request COMPONENT NAME ansible.posix.firewalld ADDITIONAL INFORMATION Related ansible-collections#582 and ansible-collections#584 Reviewed-by: Adam Miller <[email protected]> Reviewed-by: Andrew Klychkov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Changed the type of icmp_block_inversion option from
strtoboolISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION
Related #582 and #584