Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove comment from fstab entry on updating. #597

Merged
merged 3 commits into from
Nov 29, 2024
Merged

Remove comment from fstab entry on updating. #597

merged 3 commits into from
Nov 29, 2024

Conversation

vbotka
Copy link
Contributor

@vbotka vbotka commented Nov 21, 2024

SUMMARY

Fix #595.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ansible.posix.mount

ADDITIONAL INFORMATION

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/4848267fcd2041d9b81c1c77f07422b6

✔️ ansible-galaxy-importer SUCCESS in 4m 12s
✔️ build-ansible-collection SUCCESS in 5m 17s

@vbotka vbotka mentioned this pull request Nov 28, 2024
Closed
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/6303cbbd6cba4233b298218a658b5ce7

✔️ ansible-galaxy-importer SUCCESS in 4m 46s
✔️ build-ansible-collection SUCCESS in 5m 27s

saito-hideki
saito-hideki requested changes Nov 29, 2024
View reviewed changes
Copy link
Collaborator

@saito-hideki saito-hideki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! :)
In the changelog fragment file, I think it would be better to replace fstab with mount as the affected module name.

changelogs/fragments/597_remove_fstab_comment_on_updating.yml Outdated
@@ -0,0 +1,3 @@
---
bugfixes:
- fstab - If a comment is appended to a fstab entry, state present creates a double-entry (https://github.com/ansible-collections/ansible.posix/issues/595).
Copy link
Collaborator

@saito-hideki saito-hideki Nov 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to replace fstab with mount as the affected module name.
Once you fix it, I will start the merge process for this PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. I fixed the fragment. Sorry for the noise. Thank you!

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/29b62be57bb6418ba73e635ca03c94d9

✔️ ansible-galaxy-importer SUCCESS in 3m 52s
✔️ build-ansible-collection SUCCESS in 6m 14s

saito-hideki
saito-hideki approved these changes Nov 29, 2024
View reviewed changes
Copy link
Collaborator

@saito-hideki saito-hideki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
Thanks so much for taking the time to address my comments :)

@saito-hideki saito-hideki added the mergeit Gate PR in Zuul CI label Nov 29, 2024
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/78b2c4c200ae49b0bf61b5daee3a5672

✔️ ansible-galaxy-importer SUCCESS in 2m 54s
✔️ build-ansible-collection SUCCESS in 5m 16s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 74edb72 into ansible-collections:main Nov 29, 2024
45 checks passed
@vbotka vbotka deleted the mount-fix-comment branch November 29, 2024 06:50
saito-hideki pushed a commit to saito-hideki/ansible.posix that referenced this pull request Dec 3, 2024
@softwarefactory-project-zuul @saito-hideki
Merge pull request ansible-collections#597 from vbotka/mount-fix-comment
f61bb76 
 Remove comment from fstab entry on updating.

SUMMARY
Fix ansible-collections#595.
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
ansible.posix.mount
ADDITIONAL INFORMATION

Reviewed-by: Hideki Saito <[email protected]>
Reviewed-by: Vladimir Botka <[email protected]>
@saito-hideki saito-hideki mentioned this pull request Dec 3, 2024
Merged
softwarefactory-project-zuul bot added a commit that referenced this pull request Dec 3, 2024
@softwarefactory-project-zuul
Merge pull request #599 from saito-hideki/stable-2
e8fc89f 
[Backport] cherrypick #597 and #598 to stable-2 branch

SUMMARY
Merge the following two PRs to stable-2 as a cherrypick

#598
#597

ISSUE TYPE

Backport Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION
None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saito-hideki saito-hideki saito-hideki approved these changes

Assignees
No one assigned
Labels
mergeit Gate PR in Zuul CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

If a comment is appended to a fstab entry state present creates a double-entry .
2 participants
@vbotka @saito-hideki