Adds lazy reader support for long strings #630
Conversation
Codecov ReportPatch coverage is
📢 Thoughts on this report? Let us know!. |
| @@ -30,20 +30,25 @@ use crate::{IonError, IonResult, IonType, TimestampPrecision}; | |||
|
|
|||
| impl<'a> Debug for TextBufferView<'a> { | |||
| fn fmt(&self, f: &mut Formatter<'_>) -> std::fmt::Result { | |||
| const CHARS_TO_SHOW: usize = 64; | |||
There was a problem hiding this comment.
🗺️ Changes in this method are just introducing a named constant and bumping the number of characters printed from 32 to 64.
| fail(self) | ||
| /// Matches a long string comprised of any number of `'''`-enclosed segments interleaved | ||
| /// with optional comments and whitespace. | ||
| pub fn match_long_string(self) -> IonParseResult<'data, MatchedString> { |
There was a problem hiding this comment.
🗺️ I recommend going to look at the MatchedString enum before reading this implementation. It explains why we're tracking the number of segments and the presence of escaped characters.
| input: format!("{input} "), // add trailing space | ||
| input: format!("{input}\n0"), // add whitespace and a trailing value |
There was a problem hiding this comment.
🗺️ Long string syntax is very greedy. It's impossible to declare a long string "complete" until you've run into something that isn't a long string. Later on I'll add support for declaring that the input stream is done, but for the moment this workaround allows me to use the same test infrastructure on long strings.
Builds on outstanding PRs #612, #613, #614, #616, #617, #619, #620, #621, #622, #623, #627, #628 and #629.
Adds lazy reader support for long strings.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.