Adds lazy reader support for decimals #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage is
📢 Thoughts on this report? Let us know!. |
This was referenced Aug 20, 2023
popematt
approved these changes
Aug 22, 2023
| MatchTest::new(input).expect_mismatch(match_length(TextBufferView::match_decimal)); | ||
| } | ||
| let good_inputs = &[ | ||
| "5.", "-5.", "5.0", "-5.0", "5.0d0", "-5.0d0", "5.0D0", "-5.0D0", "5.0d+1", "-5.0d-1", |
There was a problem hiding this comment.
Can you add 5d0 and 5.d0 (basically, decimals that have an exponent but no fractional digits)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on outstanding PRs #612, #613, #614, #616, #617, #619, #620, #621, #622, #623, and #627.
Adds lazy reader support for decimals.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.