-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds LazyRawTextReader
support for reading IVMs
#620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #620 +/- ##
==========================================
- Coverage 81.65% 81.11% -0.54%
==========================================
Files 122 123 +1
Lines 22235 22570 +335
Branches 22235 22570 +335
==========================================
+ Hits 18155 18308 +153
- Misses 2411 2574 +163
- Partials 1669 1688 +19
☔ View full report in Codecov by Sentry. |
This was referenced Aug 11, 2023
This was referenced Aug 18, 2023
popematt
approved these changes
Aug 21, 2023
match_ivm("$ion_124_17"); | ||
|
||
mismatch_ivm("ion_1_0"); | ||
mismatch_ivm("$ion__1_0"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's another test case to consider.
Suggested change
mismatch_ivm("$ion__1_0"); | |
mismatch_ivm("$ion__1_0"); | |
mismatch_ivm("$ion_1_0_0"); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on outstanding PRs #609, #612, #613, #614, #616, #617, and #619.
Adds support for reading Ion version markers (IVMs) to the
LazyRawTextReader
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.