Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds LazyRawTextReader support for comments #613

Merged
merged 6 commits into from
Aug 22, 2023
Merged

Adds LazyRawTextReader support for comments #613

merged 6 commits into from
Aug 22, 2023

Conversation

zslayton
Copy link
Contributor

@zslayton zslayton commented Jul 27, 2023

Builds on #609 and #612. Adds support for reading

// rest-of-the-line

and

/* multi
    line  */

comments.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@zslayton zslayton changed the base branch from main to lazy-float July 27, 2023 18:23
@zslayton zslayton marked this pull request as ready for review July 27, 2023 18:24
@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Patch coverage: 98.24% and project coverage change: +0.01% 🎉

Comparison is base (789f2fb) 81.64% compared to head (fba4677) 81.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #613      +/-   ##
==========================================
+ Coverage   81.64%   81.66%   +0.01%     
==========================================
  Files         118      118              
  Lines       21147    21202      +55     
  Branches    21147    21202      +55     
==========================================
+ Hits        17266    17315      +49     
- Misses       2225     2231       +6     
  Partials     1656     1656              
Files Changed Coverage Δ
src/lazy/text/raw/reader.rs 72.35% <94.44%> (+4.13%) ⬆️
src/lazy/text/buffer.rs 85.21% <100.00%> (-0.04%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zslayton
Copy link
Contributor Author

One of the unit tests in the windows GitHub action fails sporadically due to different float rounding behavior. I've captured that in #625 and will address it when the merge queue is empty.

Base automatically changed from lazy-float to main August 22, 2023 00:12
@zslayton zslayton merged commit b00fb2f into main Aug 22, 2023
@zslayton zslayton deleted the lazy-comments branch August 22, 2023 08:29
@zslayton zslayton self-assigned this Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants