Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

Fixes #1872: Command arguments lost when invokeCommand is called with… #2052

Merged

Conversation

wu-edward
Copy link

… @executeInDrupalVm within a Robo watch task.

Fixes #1872 .

Changes proposed:

  • Use command input from CommandConsoleEvent to create new input
  • Pass in all arguments to new input constructor so that validation does not fail on missing arguments.

…d with @executeInDrupalVm within a Robo watch task.
@grasmash grasmash merged commit c064bc2 into acquia:8.x Sep 29, 2017
briantully added a commit to briantully/blt that referenced this pull request Feb 8, 2018
* acquia/8.x: (1264 commits)
  Update composer.json
  Use the correct command for setup.strategy = sync (acquia#2097)
  Provide better Memcached boilerplate config. (acquia#2063)
  Note about docker and headless chrome (acquia#2091)
  Fixes acquia#2072: temporarily disabling checking of features overrides. (acquia#2082)
  Drupal 8.4 compatibility improvements. (acquia#2080)
  Update .travis.yml
  Removing sudo from Travis. (acquia#2066)
  Fixes acquia#2059: override site uri during deploy:update. (acquia#2060)
  Remove any NULL arguments from original command being passed into VM, so that missing arguments detected faster. (acquia#2058)
  Add additional settings file include options acquia#2054 (acquia#2055)
  Add support for Apache Solr search (Acquia Search) acquia#412. (acquia#2053)
  Fixes acquia#1872: Command arguments lost when invokeCommand is called with @executeInDrupalVm within a Robo watch task. (acquia#2052)
  Cleaning up composer requirements. (acquia#2050)
  Update configuration-management.md (acquia#2051)
  Fixes acquia#2048: PHP Warning when using modules.local.uninstall: null. (acquia#2049)
  Fixes acquia#2046: Modifying BLT Configuration definition is not accurate. (acquia#2047)
  Fixes acquia#2040: Assert existence of .nvmrc or .node-version. (acquia#2042)
  Add back line removed in acquia#2039 (acquia#2043)
  Fix spacing in simplesamlphp setup readme. (acquia#2044)
  ...
@wu-edward wu-edward deleted the issue-1872-command-arguments-lost-drupalvm branch September 10, 2018 15:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants