Command arguments lost when invokeCommand is called with @executeInDrupalVm within a Robo watch task

[bobbygryzynger]

Clarifies #1866.

My system information:

• Operating system type: macOS
• Operating system version: 10.12.5
• BLT version: 8.9.0

When I run invokeCommand within a Robo watch task on a command which uses the @executeInDrupalVm annotation:

<?php

namespace Acquia\Blt\Custom\Commands;

use Acquia\Blt\Robo\BltTasks;
use Lurker\Event\FilesystemEvent;

class WatchCommand extends BltTasks {

  /**
   * @command hello
   * @param string $friend
   * @executeInDrupalVm
   */
  public function hello($friend) {
    $this->say("Hello, $friend.");
  }

  /**
   * @command watch
   */
  public function watch() {
    $this->taskWatch()
    ->monitor($this->getConfigValue('repo.root'), function(FilesystemEvent $event) {
      $this->invokeCommand('hello', ['friend' => 'friend']);
    })->run();
  }

}

When I run this command and alter a file:

blt watch

I get the following output:

$ blt watch
[Watch] Watching /Users/<user>/Sites/<project> for changes...
> hello
Executing command blt hello --define drush.alias=self inside of Drupal VM...
[warning] The xDebug extension is loaded. This will significantly decrease performance.

                                                          
  [Symfony\Component\Console\Exception\RuntimeException]  
  Not enough arguments (missing: "friend").               
                                                          

hello [-h|--help] [-q|--quiet] [-v|vv|vvv|--verbose] [-V|--version] [--ansi] [--no-ansi] [-n|--no-interaction] [-y|--yes] [-D|--define DEFINE] [--] <command> <friend>

If I remove the @executeInDrupalVm annotation I get the expected output:

$ blt watch
[Watch] Watching /Users/<user>/Sites/<project> for changes...
> hello
Hello, friend.

[grasmash]

Can you test the changes made by #1998 ?

[bobbygryzynger]

@grasmash I'm afraid I'm still seeing the same behavior described above. When @executeInDrupalVm is used I get the following output:

[Watch] Watching /Users/<user>/Sites/<project> for changes...
> hello
[error]  Not enough arguments (missing: "friend"). 

The required argument still isn't getting passed along.

[bobbygryzynger]

@grasmash I'm also finding that #1988 strips off global --define arguments. I would expect that global assignments would be preserved through sub-invokations.