deploy:update command fails to update all multisites

[bobbygryzynger]

My system information:

• BLT version: 8.x

When I run this command:

blt deploy:update

The updates are continuously run on only one multisite.

BLT loops over the multisite values, but before overriding the uri value it checks to see if it is already set and doesn't override it if a configuration value already exists.

This logic doesn't work because the uri will be set to default initially and this logic prevents the updates from being applied to any other site. This results in updates being (erroneously) applied to the initial uri multiple times.

From src/Robo/Commands/Deploy/DeployCommand.php

public function updateSites() {
  ...
  foreach ($this->getConfigValue('multisites') as $multisite) {
    $this->say("Deploying updates to $multisite...");
    if (!$this->config->get('drush.uri')) {
      $this->config->set('drush.uri', $multisite);
    }
  }
  ...
}