Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

BLT / Features Incompatibility #2072

Closed
mikemadison13 opened this issue Oct 3, 2017 · 4 comments
Closed

BLT / Features Incompatibility #2072

mikemadison13 opened this issue Oct 3, 2017 · 4 comments
Assignees
Labels
Bug Something isn't working

Comments

@mikemadison13
Copy link
Contributor

My system information:

  • Operating system type: Mac OS
  • Operating system version: 10.11.6
  • BLT version: 8.x-dev cfe62bd

When I run this command:

blt setup

I get the following output:

Checking for features overrides...
[Acquia\Blt\Robo\Tasks\DrushTask] Running /var/www/<project>/vendor/bin/drush fl --bundle=<project> --uri=default in /var/www/<project>/docroot
PHP Fatal error:  Call to undefined function drush_hide_output_fields() in /var/www/<project>/docroot/modules/contrib/features/drush/features.drush.inc on line 218

Fatal error: Call to undefined function drush_hide_output_fields() in /var/www/<project>/docroot/modules/contrib/features/drush/features.drush.inc on line 218
 [error]  Drush command terminated abnormally due to an unrecoverable error.
Error: Call to undefined function drush_hide_output_fields() in /var/www/<project>/docroot/modules/contrib/features/drush/features.drush.inc, line 218 
[Acquia\Blt\Robo\Tasks\DrushTask]  Exit code 255  Time 3.967s
[error]  Unable to determine if features in bundle <project> are overridden. 
[error]  Command `setup:config-import ` exited with code 1. 
Connection to 127.0.0.1 closed.
macbookpro-mikemadison:<project> mike.madison$ drush @<project>.local features-list-packages --format=json --bundle=<project>
 [error]  Unknown option: --format.  See `drush help features-list-packages` for available options. To suppress this error, add the option --strict=0. 
Connection to local.<project>.com closed.
 [error]  Unknown option: --format.  See `drush help features-list-packages` for available options. To suppress this error, add the option --strict=0. 

And I expected this to happen:

It would appear that Features is not compatible with Drush 9. I have bugged this issue here: https://www.drupal.org/node/2913651

In the meantime, the thing that is exploding is the final step where we check for features overrides because the features-list-packages code has a function that isn't supported in Drush 9. We could potentially remove this portion of the features import process and bypass the incompatibility.

@grasmash grasmash added the Bug Something isn't working label Oct 3, 2017
@danepowell
Copy link
Contributor

As a temporary workaround, I think you can disable the Features overrides check by setting cm.features.no-overrides = false in project.yml.

@mikemadison13
Copy link
Contributor Author

this override DID work.

should we comment out the features overrides check for the time being in BLT so not everyone has to do this?

@grasmash
Copy link
Contributor

grasmash commented Oct 4, 2017

Yes.

@mikemadison13
Copy link
Contributor Author

i'll get a PR going for that @grasmash

@grasmash grasmash self-assigned this Oct 4, 2017
briantully added a commit to briantully/blt that referenced this issue Feb 8, 2018
* acquia/8.x: (1264 commits)
  Update composer.json
  Use the correct command for setup.strategy = sync (acquia#2097)
  Provide better Memcached boilerplate config. (acquia#2063)
  Note about docker and headless chrome (acquia#2091)
  Fixes acquia#2072: temporarily disabling checking of features overrides. (acquia#2082)
  Drupal 8.4 compatibility improvements. (acquia#2080)
  Update .travis.yml
  Removing sudo from Travis. (acquia#2066)
  Fixes acquia#2059: override site uri during deploy:update. (acquia#2060)
  Remove any NULL arguments from original command being passed into VM, so that missing arguments detected faster. (acquia#2058)
  Add additional settings file include options acquia#2054 (acquia#2055)
  Add support for Apache Solr search (Acquia Search) acquia#412. (acquia#2053)
  Fixes acquia#1872: Command arguments lost when invokeCommand is called with @executeInDrupalVm within a Robo watch task. (acquia#2052)
  Cleaning up composer requirements. (acquia#2050)
  Update configuration-management.md (acquia#2051)
  Fixes acquia#2048: PHP Warning when using modules.local.uninstall: null. (acquia#2049)
  Fixes acquia#2046: Modifying BLT Configuration definition is not accurate. (acquia#2047)
  Fixes acquia#2040: Assert existence of .nvmrc or .node-version. (acquia#2042)
  Add back line removed in acquia#2039 (acquia#2043)
  Fix spacing in simplesamlphp setup readme. (acquia#2044)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants