Search block: Remove unnecessary useEffects #52519
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scruffian
added
the
[Block] Search
|
Size Change: -34 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in ece768c. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5522563462
|
jffng
previously approved these changes
Jul 11, 2023
ajlende
reviewed
Jul 11, 2023
There was a problem hiding this comment.
isSearchFieldHidden looks like it's also used for adding wp-block-search__searchfield-hidden which won't be updated when the block is selected/deselected.
gutenberg/packages/block-library/src/search/style.scss
Lines 97 to 116 in a25cb9d
^^^ Not sure if this is important (even if it is !important 😉), but I figured I'd mention it.
|
You're right, we do need to set the attribute. I changed the approach here, but it creates a warning. Not sure what we can do here. I'll close unless someone has an idea :) |
|
Block attributes shouldn't be based on the Fortunately, it looks like |
|
If I understand the issue correctly, what about the approach of not using the That is, always display the input field when the block is selected, and only the button otherwise, eliminating the hasOnlyButton && ! isSelected
? 'wp-block-search__searchfield-hidden'
: undefined12a75b413a14a9af4f7164309d2486d6.mp4 |
scruffian
force-pushed
the
remove/search-block-useEffects
branch
from
3ca85dd to
739289e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
While looking into #52342 I discovered that we can simplify the code of the search block quite a bit.
Why?
useEffects run every time the component is rendered. We should avoid this for performance reasons if we can.
How?
Rather than triggering this code on every render, I think we can just update the logic about when to show the text field. This is also less code.
Testing Instructions