Search Block: Button Only style creates unnecessary undo history

[t-hamano]

Description

When a search block is "Button only" style, clicking on the block will create an unnecessary undo history. This is because the attribute isSearchFieldHidden is updated via useEffect when isSelected prop is changed:

gutenberg/packages/block-library/src/search/edit.js

Lines 146 to 163 in 5f30ade

	useEffect( () => {
	if ( hasOnlyButton && ! isSelected ) {
	setAttributes( {
	isSearchFieldHidden: true,
	} );
	}
	}, [ hasOnlyButton, isSelected, setAttributes ] );
	// Show the search field when width changes.
	useEffect( () => {
	if ( ! hasOnlyButton || ! isSelected ) {
	return;
	}
	setAttributes( {
	isSearchFieldHidden: false,
	} );
	}, [ hasOnlyButton, isSelected, setAttributes, width ] );

This attribute is referenced only by the Edit component and appears to be used only to control the class name. In such cases, attributes should not be used and should be able to be determined by a combination of state or existing props.

Screenshots, screen recording, code snippet

8abf14b35da11f232f341dcbfd1978b9.mp4

[Mamaduka]

Should be resolved via #52519.

[t-hamano]

Oh, thanks for letting me know 😅