Search block: Remove unnecessary useEffects

WordPress · Jul 11, 2023 · ece768c · ece768c
1 parent e6c4f7e
commit ece768c
Showing 1 changed file with 4 additions and 19 deletions.
diff --git a/packages/block-library/src/search/edit.js b/packages/block-library/src/search/edit.js
@@ -142,25 +142,6 @@ export default function SearchEdit( {
 		defaultValues: { '%': PC_WIDTH_DEFAULT, px: PX_WIDTH_DEFAULT },
 	} );
 
-	useEffect( () => {
-		if ( hasOnlyButton && ! isSelected ) {
-			setAttributes( {
-				isSearchFieldHidden: true,
-			} );
-		}
-	}, [ hasOnlyButton, isSelected, setAttributes ] );
-
-	// Show the search field when width changes.
-	useEffect( () => {
-		if ( ! hasOnlyButton || ! isSelected ) {
-			return;
-		}
-
-		setAttributes( {
-			isSearchFieldHidden: false,
-		} );
-	}, [ hasOnlyButton, isSelected, setAttributes, width ] );
-
 	const getBlockClassNames = () => {
 		return classnames(
 			className,
@@ -263,6 +244,10 @@ export default function SearchEdit( {
 	};
 
 	const renderTextField = () => {
+		if ( hasOnlyButton && ! isSelected ) {
+			return;
+		}
+
 		// If the input is inside the wrapper, the wrapper gets the border color styles/classes, not the input control.
 		const textFieldClasses = classnames(
 			'wp-block-search__input',