Remove attribute

WordPress · Jul 14, 2023 · 3ca85dd · 3ca85dd
1 parent aa4cdd8
commit 3ca85dd
Showing 1 changed file with 5 additions and 14 deletions.
diff --git a/packages/block-library/src/search/edit.js b/packages/block-library/src/search/edit.js
@@ -19,7 +19,7 @@ import {
 	useSetting,
 } from '@wordpress/block-editor';
 import { useDispatch, useSelect } from '@wordpress/data';
-import { useEffect, useRef } from '@wordpress/element';
+import { useEffect, useRef, useState } from '@wordpress/element';
 import {
 	ToolbarDropdownMenu,
 	ToolbarGroup,
@@ -80,10 +80,8 @@ export default function SearchEdit( {
 		buttonPosition,
 		buttonUseIcon,
 		buttonBehavior,
-		isSearchFieldHidden,
 		style,
 	} = attributes;
-
 	const insertedInNavigationBlock = useSelect(
 		( select ) => {
 			const { getBlockParentsByBlockName, wasBlockJustInserted } =
@@ -136,16 +134,15 @@ export default function SearchEdit( {
 	const hasOnlyButton = 'button-only' === buttonPosition;
 	const searchFieldRef = useRef();
 	const buttonRef = useRef();
+	const [ isSearchFieldHidden, setIsSearchFieldHidden ] = useState(
+		hasOnlyButton && ! isSelected
+	);
 
 	const units = useCustomUnits( {
 		availableUnits: [ '%', 'px' ],
 		defaultValues: { '%': PC_WIDTH_DEFAULT, px: PX_WIDTH_DEFAULT },
 	} );
 
-	setAttributes( {
-		isSearchFieldHidden: hasOnlyButton && ! isSelected,
-	} );
-
 	const getBlockClassNames = () => {
 		return classnames(
 			className,
@@ -181,7 +178,6 @@ export default function SearchEdit( {
 			onClick: () => {
 				setAttributes( {
 					buttonPosition: 'button-outside',
-					isSearchFieldHidden: false,
 				} );
 			},
 		},
@@ -193,7 +189,6 @@ export default function SearchEdit( {
 			onClick: () => {
 				setAttributes( {
 					buttonPosition: 'button-inside',
-					isSearchFieldHidden: false,
 				} );
 			},
 		},
@@ -205,7 +200,6 @@ export default function SearchEdit( {
 			onClick: () => {
 				setAttributes( {
 					buttonPosition: 'no-button',
-					isSearchFieldHidden: false,
 				} );
 			},
 		},
@@ -217,7 +211,6 @@ export default function SearchEdit( {
 			onClick: () => {
 				setAttributes( {
 					buttonPosition: 'button-only',
-					isSearchFieldHidden: true,
 				} );
 			},
 		},
@@ -302,9 +295,7 @@ export default function SearchEdit( {
 		};
 		const handleButtonClick = () => {
 			if ( hasOnlyButton && BUTTON_BEHAVIOR_EXPAND === buttonBehavior ) {
-				setAttributes( {
-					isSearchFieldHidden: ! isSearchFieldHidden,
-				} );
+				setIsSearchFieldHidden( ! isSearchFieldHidden );
 			}
 		};