-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tiledbsoma 1.16.0rc1 pre-check,main
branch
#283
Conversation
ee79003
to
a416834
Compare
Derp, thanks for the reminders you had been so thorough to set for me, and which I had misplaced. Thank you @jdblischak ! |
…nda-forge-pinning 2025.03.05.16.19.52
….com/TileDB-Inc/tiledbsoma-feedstock into kerl/tiledbsoma-1.16.0-rc1-pre-check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a deal breaker, but it would be nice to add -DSPDLOG_LINK_SHARED=ON
to build-libtiledbsoma.sh
to finally fix the dynamic linking to spdlog
Yup, still iterating with commits -- thanks @jdblischak ! |
main
branch
I'm baffled by the CI fail here:
-- I'm googling that one now as this is a new one to me |
-- I have never seen this before. As a first attempt, I'll rerun the CI just in case the issue involves |
|
I think I found the issue: https://github.com/conda-forge/somacore-feedstock now (newly) exists and is still at 1.0.26 while https://github.com/TileDB-Inc/somacore-feedstock is at 1.0.28. |
Regardless we do still want our own channel as higher-pri |
Changing channel priority is bad b/c now a new fail with
So: now that https://github.com/conda-forge/somacore-feedstock exists, I need to add a new release-blocking step to |
4f5a6f4
to
c75be7a
Compare
Closing per our established procedure |
Nice troubleshooting @johnkerl! I hadn't considered this potential problem when somacore and tiledbsoma-py were added upstream to conda-forge. This means that the somacore installed in these feedstock builds is the one from conda-forge. In light of this:
|
This puzzled me at first glance, but now I understand it. The |
Agreed! I've marked this as a follow-up item for myself after we get 1.16.0 out.
I'm open to Conda-expert advice (I am not a Conda expert) but the googling I did do told me strict priority is important for solve times, and I don't want slower solve times. |
Good point! If we're fine with installing somacore from conda-forge, let's keep the strict channel priority. Personally, the reason strict channel priority is important is because otherwise users that install packages from many different channels end up with "frankenstein" conda environments where their packages come from a mishmash of different places. This leads to hard-to-decipher errors (because packages from different channels won't necessarily be compatible), and also makes it hard to ever reproduce that conda environment. It's much safer to install almost everything from a single channel (eg conda-forge) and then only diverge from this for specific packages you need from other special channels. |
💯 |
Need to test-drive spatial dependencies for [sc-64100] |
Current blocking path to get us
Current is 0.2.3 https://anaconda.org/conda-forge/spatialdata/files |
Re-closing. The |
Following our established procedure
single-cell-data/TileDB-SOMA#3720
[sc-63626]
Sibling of #284. Replays #275.