Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tiledbsoma 1.16.0rc1 pre-check,main branch #283

Closed
wants to merge 9 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .ci_support/osx_64_.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
MACOSX_DEPLOYMENT_TARGET:
- '11.0'
MACOSX_SDK_VERSION:
- '11.0'
- '13.3'
c_compiler:
- clang
c_compiler_version:
Expand Down
4 changes: 0 additions & 4 deletions .github/scripts/nightly/update-feedstock.sh
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,5 @@ sed -i \
s/"tiledb rc"/"tiledb nightlies"/ \
recipe/conda_build_config.yaml

# Apply patch from Xanthos to support C++20
# https://github.com/TileDB-Inc/tiledbsoma-feedstock/pull/246
patch -p1 < .github/scripts/nightly/cpp20.patch

# Print differences
git --no-pager diff conda-forge.yml recipe/conda_build_config.yaml
2 changes: 2 additions & 0 deletions .gitignore

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions recipe/build-libtiledbsoma.sh
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@

set -exo pipefail

# Clear default compiler flags
export CXXFLAGS=${CXXFLAGS//"-fvisibility-inlines-hidden"/}

mkdir libtiledbsoma-build && cd libtiledbsoma-build

cmake \
Expand All @@ -10,6 +13,7 @@ cmake \
-DCMAKE_BUILD_TYPE=Release \
-DTILEDBSOMA_BUILD_CLI=OFF \
-DTILEDBSOMA_ENABLE_TESTING=OFF \
-DSPDLOG_LINK_SHARED=ON \
../libtiledbsoma

make -j ${CPU_COUNT}
Expand Down
19 changes: 13 additions & 6 deletions recipe/build-r-tiledbsoma.sh
Original file line number Diff line number Diff line change
Expand Up @@ -4,21 +4,28 @@ set -ex

cd apis/r

# Clear default compiler flags
export CXXFLAGS=${CXXFLAGS//"-fvisibility-inlines-hidden"/}

export DISABLE_AUTOBREW=1

# https://github.com/conda-forge/r-tiledb-feedstock/commit/29cb6816636e7b5b58545e1407a8f0c29ff9dc39
if [[ $target_platform == osx-64 ]]; then
if [[ $target_platform == osx-* ]]; then
export NN_CXX_ORIG=$CXX
export NN_CC_ORIG=$CC
export CXX=$RECIPE_DIR/cxx_wrap.sh
export CC=$RECIPE_DIR/cc_wrap.sh
mkdir -p ~/.R
echo CC=$RECIPE_DIR/cc_wrap.sh > ~/.R/Makevars
echo CXX=$RECIPE_DIR/cxx_wrap.sh >> ~/.R/Makevars
echo CXX17=$RECIPE_DIR/cxx_wrap.sh >> ~/.R/Makevars
fi

export CXX17FLAGS="-Wno-deprecated-declarations -Wno-deprecated"
export CXX="$CXX -std=c++20 -fPIC"
export CXX20="$CXX"

mkdir -p ~/.R
echo CC="$CC" > ~/.R/Makevars
echo CXX="$CXX" >> ~/.R/Makevars
echo CXX20="$CXX20" >> ~/.R/Makevars

export CXX20FLAGS="-Wno-deprecated-declarations -Wno-deprecated"

# https://conda-forge.org/docs/maintainer/knowledge_base/#newer-c-features-with-old-sdk
if [[ $target_platform == osx-* ]]; then
Expand Down
3 changes: 3 additions & 0 deletions recipe/build-tiledbsoma-py.sh
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ set -ex

cd apis/python

# Clear default compiler flags
export CXXFLAGS=${CXXFLAGS//"-fvisibility-inlines-hidden"/}

echo
echo "PKG_VERSION IS <<$PKG_VERSION>>"
echo
Expand Down
3 changes: 1 addition & 2 deletions recipe/cc_wrap.sh
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
#!/bin/sh

args="${@##-mmacosx-version-min=10.9*}"
$NN_CC_ORIG $args -mmacosx-version-min=11.0
$NN_CC_ORIG "$@" -mmacosx-version-min=13.3
2 changes: 1 addition & 1 deletion recipe/conda_build_config.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# https://conda-forge.org/docs/maintainer/knowledge_base/#requiring-newer-macos-sdks
# https://conda-forge.org/news/2024/03/24/stdlib-migration/
MACOSX_SDK_VERSION: # [osx and x86_64]
- 11.0 # [osx and x86_64]
- 13.3 # [osx and x86_64]
c_stdlib_version: # [osx and x86_64]
- 11.0 # [osx and x86_64]
channel_sources:
Expand Down
3 changes: 1 addition & 2 deletions recipe/cxx_wrap.sh
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
#!/bin/sh

args="${@##-mmacosx-version-min=10.9*}"
$NN_CXX_ORIG $args -mmacosx-version-min=11.0
$NN_CXX_ORIG "$@" -mmacosx-version-min=13.3
32 changes: 19 additions & 13 deletions recipe/meta.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{% set name = "tiledbsoma" %}
{% set version = "1.15.7" %}
{% set sha256 = "ecdcafc2cb83e392e1102fea11e910548bcacdb854b5bc365c96ef940fed0c3f" %}
{% set version = "1.16.0rc1" %}
{% set sha256 = "tbd" %}
# This is the SHA256 of
# TileDB-SOMA-i.j.k.tar.gz
# from
Expand All @@ -15,18 +15,18 @@ package:
name: {{ name }}
version: {{ version }}

# Post-tag real thing:
source:
url: https://github.com/single-cell-data/TileDB-SOMA/archive/{{ version }}.tar.gz
sha256: {{ sha256 }}
## Post-tag real thing:
#source:
# url: https://github.com/single-cell-data/TileDB-SOMA/archive/{{ version }}.tar.gz
# sha256: {{ sha256 }}

# Pre-tag canary "will Conda be green if we release":
#source:
# git_url: https://github.com/single-cell-data/TileDB-SOMA.git
# # release-1.15 branch 2025-01-24
# git_rev: ceb4a3682663dfc74a346c91cc5bfa85a0b0674c
# git_depth: -1
# # hoping to be 1.15.5 <-- FILL IN HERE
source:
git_url: https://github.com/single-cell-data/TileDB-SOMA.git
# release-1.16 branch 2025-03-05
git_rev: 1f12399f17297b75ed9205643e1719cabc9a961c
git_depth: -1
# hoping to be 1.16.0rc1 <-- FILL IN HERE

build:
number: 0
Expand Down Expand Up @@ -99,8 +99,14 @@ outputs:
- numba >=0.58.1
- attrs >=22.2
# Keep this in sync with TileDB-SOMA's somacore version requirement.
- somacore ==1.0.26
- somacore ==1.0.28
- scanpy >=1.9.2
# See TileDB-SOMA's apis/python/requirements_spatial.txt
- geopandas
- tifffile
- pillow
- spatialdata >=0.2.5
- xarray
test:
imports:
- tiledbsoma
Expand Down
Loading