Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

somacore 1.0.28 #3

Merged
merged 3 commits into from
Mar 6, 2025
Merged

Conversation

johnkerl
Copy link
Contributor

@johnkerl johnkerl commented Mar 5, 2025

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

single-cell-data/TileDB-SOMA#3720
[sc-63626]

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/recipe.yaml) and found it was in an excellent condition.

@johnkerl
Copy link
Contributor Author

johnkerl commented Mar 6, 2025

Thanks @hadim !

It looks like I can't merge this without @jdblischak 's review also ...

@hadim
Copy link
Member

hadim commented Mar 6, 2025

You can merge whenever you want as long as you are confident enough IMO.

@hadim
Copy link
Member

hadim commented Mar 6, 2025

There is no rule on c-f asking to wait for everyone's reviews, especially for simple bumping PR.

@johnkerl
Copy link
Contributor Author

johnkerl commented Mar 6, 2025

@hadim I have no merge button to push ... perhaps a permissioning issue?

Screenshot 2025-03-05 at 8 40 51 PM

@hadim
Copy link
Member

hadim commented Mar 6, 2025

Oh ok. It's because you are not on the list of maintainers in the recipe file. Do you want to be added?

@johnkerl
Copy link
Contributor Author

johnkerl commented Mar 6, 2025

@hadim yes please! 🙏

@hadim
Copy link
Member

hadim commented Mar 6, 2025

You should be good now.

@johnkerl johnkerl merged commit f059253 into conda-forge:main Mar 6, 2025
4 checks passed
@johnkerl
Copy link
Contributor Author

johnkerl commented Mar 6, 2025

Thanks @hadim!

@teo-tsirpanis teo-tsirpanis mentioned this pull request Mar 6, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants